- Notifications
You must be signed in to change notification settings - Fork 0
Keep answer source-card widths aligned and record follow-ups#2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10 docs/outstanding-issues-inbox/3a4868e6-281a-48c1-895b-82d6aade2bc7.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "3a4868e6-281a-48c1-895b-82d6aade2bc7", | ||
| "createdOn": "2026-08-25", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "8b2a3f89-9bdb-4fb1-8fd0-35165d050263", | ||
| "reason": "Implemented the requested local source-card width constant in this owning answer-page change." | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14 docs/outstanding-issues-inbox/485bdac6-7f79-4539-9d90-347866604b35.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "485bdac6-7f79-4539-9d90-347866604b35", | ||
| "createdOn": "2026-08-25", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P3", | ||
| "type": "rec", | ||
| "summary": "Overflow menus split between a real ARIA menu and menu roles with no keyboard model", | ||
| "detail": "search-pins-menu.tsx declares role=menu/menuitem but implements no arrow-key, Home/End or roving-focus handling, so it promises the ARIA menu keyboard model and delivers Tab. mode-action-popup.tsx implements the model properly. answer-source-drawer.tsx was the third shape and was changed on 2026-08-25 (PR #2370) to role=group with plain buttons — a disclosure, which is what it actually is. Next action: pick one rule for the repo and apply it to search-pins-menu.tsx — either implement the keyboard model or drop the menu roles as the drawer did. No gate covers this, so it will keep diverging. Not urgent: every one of these menus is operable by Tab today; the defect is the mismatch between what is announced and what works.", | ||
| "source": "PR #2370 review (CodeRabbit), verified in source 2026-08-25", | ||
| "issueUlid": "01M0WYC9VR76GGRGJ31X3V41CP" | ||
| } | ||
| } | ||
14 changes: 14 additions & 0 deletions
14 docs/outstanding-issues-inbox/8b2a3f89-9bdb-4fb1-8fd0-35165d050263.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "8b2a3f89-9bdb-4fb1-8fd0-35165d050263", | ||
| "createdOn": "2026-08-25", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P3", | ||
| "type": "rec", | ||
| "summary": "The answer source-rail card carries three hardcoded pixel measurements, one of them duplicated", | ||
| "detail": "answer-source-rail.tsx uses h-[22px] min-w-[22px] on the number badge and max-w-[158px] twice on the title and meta clamp. A reviewer asked for @theme tokens; that was declined on 2026-08-25 and the reasoning is worth keeping: no gate flags these (check:design-system-contract passes, and its raw-literal ratchets do not cover width/height), and naming one card's measurements as scale steps misrepresents them as a design vocabulary other surfaces should reach for. Next action, if anything: extract the duplicated 158px into one local constant in that file so the two clamps cannot drift apart. That is the only part with real value — the badge pair is used once. Do NOT convert these to @theme tokens without a second consumer.", | ||
| "source": "PR #2370 review (CodeRabbit nitpick), declined with reasons 2026-08-25", | ||
| "issueUlid": "01M0WYCQMZVVA5M289CJVFXCTJ" | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14 docs/outstanding-issues-inbox/d2a6122a-4fcd-4429-92a7-6004fa19eb24.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "d2a6122a-4fcd-4429-92a7-6004fa19eb24", | ||
| "createdOn": "2026-08-25", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P3", | ||
| "type": "task", | ||
| "summary": "Docstring coverage on the answer-source changes sits at 62.5% against CodeRabbit's 80% advisory threshold", | ||
| "detail": "CodeRabbit's pre-merge Docstring Coverage check warned on every head of PR #2370, measuring 56 functions across 17 files. It is advisory only — not a required GitHub check, and it never blocked the merge. Recorded so the next person who sees the warning knows it was read rather than missed. Next action: none required. If someone wants the number up, the gap is in small helpers and test harness functions rather than in the exported surfaces, which are documented; decide whether the threshold is measuring something this repo actually wants before writing comments to satisfy it.", | ||
| "source": "PR #2370 pre-merge checks, 2026-08-25", | ||
| "issueUlid": "01M0WYCQTP2X46NY2E10SPCE0H" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.