Skip to content

test(ward-flow): follow the phone drawer navigation contract - #2376

Merged
BigSimmo merged 3 commits into
mainfrom
codex/ward-flow-phone-test
Aug 25, 2026
Merged

test(ward-flow): follow the phone drawer navigation contract#2376
BigSimmo merged 3 commits into
mainfrom
codex/ward-flow-phone-test

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local

  • npm run verify:ui

  • npm run verify:release

  • node scripts/run-playwright.mjs tests/ui-ward-management.spec.ts --project=chromium-mockups --grep "keeps every rail mode link": 1 passed

  • npm run format: passed

  • npm run check:branch-review-ledger: passed

  • Exact-head hosted CI: Static PR checks, Build, Unit coverage, Advisory UI, Lighthouse, production UI, SAST, and Secret Scan passed.

  • Verification not run: full npm run verify:pr-local and npm run verify:release were not repeated for this one-assertion test-only follow-up; exact-head hosted CI is the merge gate.

  • UI verification not run: the broad npm run verify:ui wrapper was not repeated; the directly affected Chromium journey and all exact-head hosted production/advisory UI shards passed.

Risk and rollout

  • Risk: test-only; no product/runtime behavior changes
  • Rollback: revert the test commit
  • Provider or production effects: None
  • RAG impact: none

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

@supabase

supabaseBot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e8e6cdfd-0a24-4151-9de7-9e124402e46c

📥 Commits

Reviewing files that changed from the base of the PR and between 424db17 and dc68600.

⛔ Files ignored due to path filters (1)
  • docs/branch-review-records/a6039ca5963c0b696adfe805fe306bfb8a2733ca952dbf20800a78420abb645a.record.md is excluded by !docs/**, !**/*.md
📒 Files selected for processing (1)
  • tests/ui-ward-management.spec.ts

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The tap-target test now opens the Ward Flow menu on a 320×640 viewport before it locates and measures the eight mode links.

Changes

Ward Flow phone navigation

Layer / File(s)Summary
Open the navigation drawer before measuring mode links
tests/ui-ward-management.spec.ts
The test documentation reflects drawer-based phone navigation. The test clicks “Open Ward Flow menu” before measuring the eight mode links.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to dc686

This PR updates a single Ward Flow browser assertion to open the phone drawer before measuring navigation links and adds a review-record entry; it does not change product or runtime behavior, so no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly describes the main change: updating the Ward Flow test to follow phone drawer navigation.
Description check✅ PassedThe description includes all required template sections, documents targeted verification and skipped gates with reasons, and records risk, rollback, production effects, RAG impact, governance checks, …
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Description check

Explanation

The description includes all required template sections, documents targeted verification and skipped gates with reasons, and records risk, rollback, production effects, RAG impact, governance checks, and notes.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ward-flow-phone-test

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 25, 2026 22:02
cursor[bot]
cursorBot previously approved these changes Aug 25, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Approved. Cursor Bugbot completed successfully with no findings that need human review. No reviewers were assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Static PR checksneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #13933 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

cursor[bot]
cursorBot approved these changes Aug 25, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present after the first check poll, so that signal was skipped; no applicable approval policy requires human review, and no unresolved Bugbot findings remain. No reviewers were assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

@BigSimmo
BigSimmo merged commit e3c4c10 into mainAug 25, 2026
37 of 39 checks passed
@BigSimmo
BigSimmo deleted the codex/ward-flow-phone-test branch August 25, 2026 22:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo