Skip to content

test(ward-flow): pin demo countdown clock - #2392

Merged
BigSimmo merged 1 commit into
mainfrom
codex/pr-2384-followup
Aug 26, 2026
Merged

test(ward-flow): pin demo countdown clock#2392
BigSimmo merged 1 commit into
mainfrom
codex/pr-2384-followup

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • stabilize the Ward Flow demo countdown browser test by pinning its browser clock before navigation
  • record the post-merge review of PR Ward Flow Phase 5 documents, and three sidebar fixes the squash left behind #2384 and refresh the required repository-awareness snapshot
  • leave the coupled 64rem Ward sidebar breakpoint unchanged because tokenizing only this selector would let it diverge from the sidebar selectors it must match

Verification

  • npm run test:e2e:mockups -- tests/ui-ward-roles.spec.ts --grep "the demo clock control advances" (1 passed; isolated production build and TypeScript passed)
  • npm run check:branch-review-ledger
  • npm run check:repo-awareness-snapshot
  • npm run format

npm run verify:pr-local was not run: this is a three-line test stabilization with its generated review metadata, and the exact affected browser owner passed through the repository wrapper.

UI verification not run: the full npm run verify:ui would duplicate the exact Ward Flow browser owner already run; product UI/runtime behavior is unchanged.

Risk and rollout

  • Risk: Low; test-only clock control plus generated review metadata. Product runtime behavior is unchanged.
  • Rollback: Revert this commit.
  • Provider or production effects: None.
  • RAG impact: none

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

This PR changes only test time control and review metadata; clinical decision-support behavior is unchanged.

Notes

@supabase

supabaseBot commented Aug 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7a2ba3a3-ef69-42e1-aafc-097ed6473bff

📥 Commits

Reviewing files that changed from the base of the PR and between e15b250 and 1941b7f.

⛔ Files ignored due to path filters (1)
  • docs/branch-review-records/05dba5d5d54fbe6733f15470a3d69957522452e434e543af81b8189c5d4a04db.record.md is excluded by !docs/**, !**/*.md
📒 Files selected for processing (2)
  • data/repo-awareness-snapshot.json
  • tests/ui-ward-roles.spec.ts

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The repository snapshot now includes updated revision metadata, a new PR #2384 review record, and incremented totals. The ward-role expiry test now uses a fixed browser time before checking bed-hold countdown behavior.

Changes

Repository snapshot metadata

Layer / File(s)Summary
Update snapshot revision and review record
data/repo-awareness-snapshot.json
The snapshot records the new revision, PR #2384 review data, and updated record and reference totals.

Ward expiry test timing

Layer / File(s)Summary
Pin expiry test time
tests/ui-ward-roles.spec.ts
The held-bed expiry test sets a fixed browser timestamp before navigation and assertions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk:⚪ Minimal · up to 1941b

This PR only stabilizes a browser test and updates review metadata; product runtime behavior is unchanged, and no actionable merge-blocking risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly identifies the main change: pinning the demo countdown clock in the Ward Flow test.
Description check✅ PassedThe description follows the repository template. It documents the changes, verification results, skipped checks with reasons, risk, rollback, production effects, RAG impact, governance status, and not…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description follows the repository template. It documents the changes, verification results, skipped checks with reasons, risk, rollback, production effects, RAG impact, governance status, and notes.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/pr-2384-followup

Comment @coderabbitai help to get the list of available commands.

cursor[bot]
cursorBot approved these changes Aug 26, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot completed successfully with no findings requiring human review, and no approval policy required additional review. Reviewers were not assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

@BigSimmo
BigSimmo merged commit f5f39c3 into mainAug 26, 2026
41 of 49 checks passed
@BigSimmo
BigSimmo deleted the codex/pr-2384-followup branch August 26, 2026 07:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo