Skip to content

Redesign DSM compare page for compact header and mobile-friendly layout - #2409

Merged
BigSimmo merged 5 commits into
mainfrom
claude/dsm-compare-ux-redesign
Aug 27, 2026
Merged

Redesign DSM compare page for compact header and mobile-friendly layout#2409
BigSimmo merged 5 commits into
mainfrom
claude/dsm-compare-ux-redesign

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Redesign /dsm/compare with a compact DsmPageHeader (Compare diagnoses, homeIcon={false}) and unified comparison grid with ask-this prompt and footer disclaimer.
  • Add optional homeIcon?: LucideIcon | false to InformationPageBreadcrumbs for pages that should not show a back/home crumb control.
  • Extend DOM and Playwright route coverage for the new compare title and layout.

Verification

 Test Files 4 passed (4)
Tests 20 passed (20)

Risk

Low — DSM UI and breadcrumb presentation only.

RAG impact: no retrieval behaviour change — compare page layout and header chrome only.

Test plan

  • npx vitest run tests/information-page-shell.dom.test.tsx tests/dsm-comparison-page.dom.test.tsx tests/dsm.test.ts tests/dsm-compare-remove-link.dom.test.tsx
  • Manual smoke on /dsm/compare with 0/1/2/3 selected diagnoses (mobile + desktop)

Note

Low Risk
Presentation-only changes to DSM compare UI and breadcrumb chrome; no API, auth, or clinical data logic changes.

Overview
Redesigns /dsm/compare around a single responsive comparison card instead of separate selected-diagnosis tiles, a desktop table, and mobile row cards. Diagnoses are labeled A/B/C, each column shows summary plus Open record, criteria rows reuse the same badges, and Differential review is offered per diagnosis at the bottom.

The page header is tightened: title Compare diagnoses, shorter description, no page icon, and breadcrumb home can be text-only when mode nav already handles wayfinding. DsmPageHeader now points the home crumb at DSM search (dsmSearchHref) and accepts optional homeIcon / icon overrides; InformationPageBreadcrumbs adds homeIcon?: false for the same pattern elsewhere.

Adds an Ask this clinical prompt block and a centered footer disclaimer. DOM and Playwright coverage are updated for the new title and unified layout (no duplicate “Selected diagnoses” section).

Reviewed by Cursor Bugbot for commit 5c5513b. Configure here.

BigSimmoand others added 2 commits August 27, 2026 13:07
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitaiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 97 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ad97f38c-980e-41f2-951a-47349ab0fc32

📥 Commits

Reviewing files that changed from the base of the PR and between f924650 and 51d4994.

📒 Files selected for processing (7)
  • src/components/dsm/dsm-compare-chrome.tsx
  • src/components/dsm/dsm-comparison-page.tsx
  • src/components/dsm/dsm-page-header.tsx
  • src/components/information-page-shell.tsx
  • tests/dsm-comparison-page.dom.test.tsx
  • tests/information-page-shell.dom.test.tsx
  • tests/ui-route-coverage.spec.ts

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_052db315-73b0-4a32-8c5e-233f3ac1ba49)

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (1)needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #14119 (failure).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

BigSimmoand others added 2 commits August 27, 2026 13:40
Point the route-coverage remove step at the shared slot-strip button and compact cleared compare ids so the URL stays ids=<remaining>.
Co-authored-by: Cursor <cursoragent@cursor.com>
@BigSimmo
BigSimmo enabled auto-merge (squash) August 27, 2026 05:53
@BigSimmo
BigSimmo merged commit 39545f0 into mainAug 27, 2026
29 checks passed
@BigSimmo
BigSimmo deleted the claude/dsm-compare-ux-redesign branch August 27, 2026 06:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo