Skip to content

fix(ui): Specifiers Search nav + compare/builder polish - #2414

Merged
BigSimmo merged 5 commits into
mainfrom
codex/specifiers-nav-search-pr
Aug 27, 2026
Merged

fix(ui): Specifiers Search nav + compare/builder polish#2414
BigSimmo merged 5 commits into
mainfrom
codex/specifiers-nav-search-pr

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rename Specifiers mode tab Find → Search and route it to /specifiers/search (active-id, route visibility, query/filter carry), matching Factsheets/Therapy Compass.
  • Point Specifier breadcrumbs and in-page back links at the search catalogue.
  • Polish Compare: formulation-parity header (Side-by-side review), focused-distinction guide for starter pairs, Waypoints map icon.
  • Builder review footer: Map + Compare cross-links; search empty state: starter-pair + map secondary actions.
  • Playwright proofs: Search tab from compare and builder lands on /specifiers/search.

Verification

  • npx vitest run tests/mode-secondary-navigation.test.ts tests/page-secondary-navigation.dom.test.tsx68 passed
  • Verification not run: npm run verify:pr-local — unit/DOM nav contracts covered locally; full PR-local deferred to CI on this UI/nav-only change
  • UI verification not run: npm run verify:ui — Playwright proofs added in tests/ui-specifiers.spec.ts; Chromium gate deferred to CI (local Playwright production build was blocked earlier by unrelated DSM WIP)

Risk and rollout

  • Risk: Low — mode secondary navigation label/href and Specifiers UI cross-links only; no clinical data, RAG, auth, or schema changes
  • Rollback: Revert this PR
  • Provider or production effects: None
  • RAG impact: none

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • Formulation Find→Search intentionally out of scope
  • Navigation and presentation polish only; no change to specifier clinical content under src/lib/specifiers.ts

Note

Low Risk
Navigation labels, URLs, and UI cross-links only; no changes to specifier clinical data, auth, or backend behavior.

Overview
Renames the Specifiers mode tab from Find to Search and points it at /specifiers/search, with active-tab detection, workflow-route classification, and Search link generation that preserves query, run, filters, and specifier selections when switching tabs. Breadcrumbs and specifier detail back navigation now target the search catalogue instead of /specifiers.

Compare gains a formulation-style header (Side-by-side review), a Focused distinction panel for the two starter pairs (distinction, confusion, treatment), and a Waypoints icon on Browse the map. Builder review and search empty states add cross-links to the map, starter compare pairs, and compare (pre-filled when two specifiers are selected).

Tests and Playwright coverage are updated for the new labels, routes, and Search-tab navigation from compare and builder.

Reviewed by Cursor Bugbot for commit 9cfa37e. Configure here.

…uilder
Rename the specifiers mode tab from Find to Search and route it to /specifiers/search with active-id, route visibility, and query/filter carry. Align compare header and focused-distinction guide with formulation, add builder review and empty-search cross-links, and add Playwright navigation proofs from compare and builder.
Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 14 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 98 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 96d92735-a7c4-47e8-84ce-f4ca7142edbf

📥 Commits

Reviewing files that changed from the base of the PR and between 7031c42 and 9cfa37e.

📒 Files selected for processing (11)
  • src/components/specifiers/specifier-builder-page.tsx
  • src/components/specifiers/specifier-compare-page.tsx
  • src/components/specifiers/specifier-nav-header.tsx
  • src/components/specifiers/specifier-ui.tsx
  • src/components/specifiers/specifiers-home-page.tsx
  • src/lib/mode-secondary-navigation.ts
  • tests/mode-secondary-navigation.test.ts
  • tests/page-secondary-navigation.dom.test.tsx
  • tests/ui-mode-nav-density.spec.ts
  • tests/ui-route-coverage.spec.ts
  • tests/ui-specifiers.spec.ts

Comment @coderabbitai help to get the list of available commands.

@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_104f7b7b-5202-4952-971e-4372fc7b4332)

@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_005b5683-bbd8-4d25-aa47-676123844058)

@BigSimmo
BigSimmo enabled auto-merge (squash) August 27, 2026 06:42
@BigSimmo
BigSimmo merged commit e5d6ed2 into mainAug 27, 2026
35 of 36 checks passed
@BigSimmo
BigSimmo deleted the codex/specifiers-nav-search-pr branch August 27, 2026 06:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo