issues: record three follow-ups and the branch review owed by PR #2422 - #2434
Conversation
Three append-only intake requests, plus the regenerated snapshot that check:outstanding-issues requires once the inbox is non-empty. - P2 issue: Lighthouse desktop-root LCP read 961/925/900/852 on the #2422 branch against 748/705 on main, same 786ms baseline. It failed the gate once and cost a re-run. Not root-caused; recorded with the evidence on both sides, the one mechanism still testable (whether extracting answer-cancelled-notice.tsx added a chunk to /), the exact command to test it, and the caveat that the gate's 3-sample majority is taken on a single runner and so cannot see runner-level slowness. - P3 issue: /calculators/search keeps a 2px residual scroll range at 1280x1200, deliberately out of scope for #2419 because it is real content rather than the chrome-estimate floor that PR removed. - P3 task: mode-home-page-skeleton.tsx:32,60 still subtract --shell-header-h from 100dvh - the last page-fill estimates in src/ and the pattern invariant 24 retired. Left because the Suspense parent chain has to carry a definite height first. Requests are immutable and merge independently; reconciliation is a separate serial branch and is deliberately not done here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bbm7tQoyg6etyf7NqoA65d
Owed from the handoff and deliberately not pushed onto the branch while it was green and armed for auto-merge. Records the scope, the merge outcome verified by content rather than by the green tick (git diff c917e0728b1fef is empty, so the squash dropped nothing), the CI evidence on the merged head, and two honest gaps: the Chromium gate could not run in this container under the #255 revision pin, and the desktop-root LCP reading is carried as its own open item rather than reported as cleared. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bbm7tQoyg6etyf7NqoA65d
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 103 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #14242 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
`Static PR checks` failed on this branch: check:repo-awareness-snapshot reported "review_state differs from the repository". The repo-awareness snapshot mirrors the branch-review records, so appending one leaves it behind; I regenerated the outstanding-issues snapshot in the first commit and missed this second one. Regenerated with the command the check itself names. The diff is only the captured revision, the mirrored copy of the new record, and counts 2644 -> 2645 records / 1612 -> 1613 refs. Nothing unrelated moved. Verified: check:repo-awareness-snapshot now reports "in step ... (195 pages, 481 documents, 2645 reviews)"; the failure reproduced locally first. Also re-ran the rest of the failing job's docs and ledger gates plus the whole-tree format check — docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links, check:outstanding-issues, check:ledger-write-discipline, check:branch-review-ledger, format:check — all pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bbm7tQoyg6etyf7NqoA65d
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_acb38c13-0ae3-4cf4-8190-da4664ec358e) |
…ll-stability-cbnak6 # Conflicts: # data/repo-awareness-snapshot.json
…ll-stability-cbnak6 # Conflicts: # data/repo-awareness-snapshot.json
Uh oh!
There was an error while loading. Please reload this page.
Summary
Append-only memory owed by PR #2422, deliberately kept off that branch while it was green and armed for auto-merge. Two separately revertible commits plus a CI fix; no product code, no clinical content.
docs/outstanding-issues-inbox/*.json).main, same 786 ms baseline; it failed the gate once and cost a re-run. Not root-caused. The row carries the evidence on both sides (mobile-root — the same page — was unchanged at 2293/2305/2314 against a 2274 baseline, anddesktop-documents-searchmeasured faster than main on the same runners), the one mechanism still testable, the exact command to test it, and stop rules. It also records a gate caveat:majorityBreachDecisioninscripts/check-lighthouse-budget.mjstakes its three samples inside one job on one runner, so it guards against a single outlier but not against a slow runner./calculators/searchkeeps a 2px residual scroll range at 1280×1200. Out of scope for fix(ui): remove dead scroll on pages that fit the window #2419 because it is real content, not thecalc(100dvh - <estimate>)floor that PR removed.src/components/mode-home-page-skeleton.tsx:32,60still subtract--shell-header-hfrom100dvh. These are the last page-fill estimates insrc/and the exact pattern invariant 24 retired; they were left because the skeleton's Suspense parent chain has to carry a definite height first, so swapping the class alone would collapse it.claude/home-page-scroll-stability-cbnak6, recording the merge outcome verified by content rather than by the green tick —git diff c917e079 28b1fefis empty, so the squash dropped nothing — and naming two honest gaps: the Chromium gate could not run in this container under the#255revision pin, and the LCP reading is carried as an open item rather than reported as cleared.data/outstanding-issues-snapshot.jsonanddata/repo-awareness-snapshot.json. Both mirror the records above and are produced by their own generator scripts, never hand-edited. The second was missed on the first push and turnedStatic PR checksred; that is fixed here.Reconciliation is deliberately not done here; requests are immutable, merge independently, and are applied later by a dedicated serial fresh-base branch.
RAG impact: no retrieval behaviour change — this diff touches no retrieval, ranking, selection, chunking, scoring, eval-harness, or answer-generation surface.
Verification
npm run verify:pr-localRun instead, and reported exactly as run:
npm run check:repo-awareness-snapshot— reproduced the CI failure first (review_state differs from the repository), then after regenerating:in step with data/repo-awareness-snapshot.json (195 pages, 481 documents, 2645 reviews).npm run check:outstanding-issues—[snapshot] in step with data/outstanding-issues-snapshot.json (81 open, 3 pending).npm run check:ledger-write-discipline—Ledger write discipline passed for 28b1fef42932..HEAD.Run after committing, because the gate compares two committed refs and an uncommitted ledger edit is invisible to it.npm run check:branch-review-ledger—880 live table records + 1206 archived + 559 immutable … immutable review writes, six cells each, no conflict markers, mojibake, heading records, or duplicates.npm run docs:check-index,docs:check-inventory,docs:check-scripts,docs:check-links— all pass.npm run formatandformat:check(whole tree, not per-file) — clean.Not run, with reasons: no lint, typecheck, unit, build, or browser gate. This diff contains no executable source — three JSON intake records, one Markdown record, and two generated JSON snapshots regenerated by their own scripts — so there is no plausible changed failure path for those gates to detect.
npm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run verify:releasebefore release or handoff confidence claimsRisk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)This PR carries no clinical content and changes no clinical behaviour: the two
data/**files are the outstanding-issues and repo-awareness snapshots, which record process memory (issue rows, review records, route and document counts) and are read by tooling, not by the answer path. The preflight is completed becauseclassifyPullRequestFilesflags anydata/**change as clinical-risk, which is the correct conservative default.Notes
data/outstanding-issues-snapshot.jsonwas exempt from clinical-risk classification. That exemption exists only for the Codex auto-fix routing hold inAGENTS.md;scripts/pr-policy.mjsis a separate mechanism and classifies everydata/**path as clinical-risk. Verified by runningclassifyPullRequestFilesagainst this PR's exact file list:clinicalRisk: true.origin/mainafter fix(ui): unstick the safety-findings sheet, settle the stopped-answer state, repoint sidebar Documents #2422 merged rather than stacked on already-merged history. The old remote branch had been auto-deleted on merge, so this pushed as a new branch with no force.