Skip to content

Correct stale Dictionary header recommendation in mockups/README.md - #2438

Closed
BigSimmo wants to merge 2 commits into
mainfrom
claude/organize-remote-mockups-15wshq
Closed

Correct stale Dictionary header recommendation in mockups/README.md#2438
BigSimmo wants to merge 2 commits into
mainfrom
claude/organize-remote-mockups-15wshq

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Follow-up to Add a topic-grouped mockup index to mockups/README.md #2423 (the mockup index PR). While re-checking other mockup groups for safe cleanup, I found that the Dictionary header round-two write-up in mockups/README.md tagged Version 02 as the recommendation, but the commit that actually shipped this study to /dictionary/browse (PR Add Dictionary Browse header redesign study with three directions #2143) records Version 01 as the chosen direction. The "(rec.)" tag was never updated after the decision changed.
  • Corrects the round-two table's tag and adds a one-line "Shipped: Version 01" note citing the shipping commit.
  • Also updates the "Dictionary browse header" entry in the topic-grouped index (added in Add a topic-grouped mockup index to mockups/README.md #2423) from "no recorded winner" to reflect that a version did ship, while clarifying that all three routes stay regardless — round two and round three both import code from round one's component file.
  • No code behaviour change — this only corrects prose/labels in a documentation file.

Verification

  • Docs-only change (mockups/README.md); no source behaviour changed.
  • Verification not run: verify:pr-local / verify:ui / verify:release — not applicable to a documentation-only edit with no code, routing, or build changes.
  • npm run format run and committed.

Risk and rollout

Not applicable — this PR does not touch clinical, data, API, auth/privacy, workflow, dependency, build, or deployment surfaces.

  • RAG impact: none

Notes

  • No mockup routes were touched in this PR.

Generated by Claude Code


Note

Low Risk
Prose-only change in mockup documentation; no application code, routing, or runtime behavior is affected.

Overview
Documentation-only fix in mockups/README.md so the Dictionary browse header mockup index matches what actually shipped.

The topic index no longer says the three header rounds have no recorded winner; it now states round two Version 01 went to /dictionary/browse, notes an earlier write-up had the wrong version, and explains all three mockup routes stay because later rounds import round one’s components.

In the round-two (2026-08-18) section, Version 02 loses the (rec.) label, and a new “Shipped: Version 01” line cites PR #2143 and ties forward to the dictionary-control-row study.

Reviewed by Cursor Bugbot for commit c4c5dcc. Configure here.

The round-two write-up tagged Version 02 as the recommendation, but the
commit that actually shipped this study to /dictionary/browse (PR #2143)
records Version 01 as the chosen direction. Confirmed via git history;
the earlier "(rec.)" tag was never updated after the decision changed.
@coderabbitai

coderabbitaiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • mockups/README.md is excluded by !mockups/**, !**/*.md

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1fa7b202-b736-48b5-88f8-93a3db06cf2c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review August 27, 2026 14:49
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 27, 2026 14:49
@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_34067dd2-42b2-495f-a7a1-585e0fe9f646)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@claude