Skip to content

fix: finalize design audit regression hardening#806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BigSimmo wants to merge 3 commits into from
Closed

fix: finalize design audit regression hardening #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bb0cae
fix: finalize design audit regression hardening
BigSimmo Jul 17, 2026
ccd3756
merge: finalize design audit regression hardening
BigSimmo Jul 17, 2026
b3bbe5a
chore: fix drift manifest parity for query-corrector function
BigSimmo Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions docs/codebase-index.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,17 +68,19 @@ Structured map for AI agents and onboarding. For live routes, see `docs/site-map

### API routes (`src/app/api/`)

| Area | Routes | Entry files |
| ----------- | ----------------------------------------------------------------------- | --------------------------------------------------------------- |
| Answers | `/api/answer`, `/api/answer/stream`, `/api/answer-feedback` | `answer/route.ts`, `answer/stream/route.ts`, `answer-feedback/` |
| Search | `/api/search`, `/api/search/interaction` | `search/` |
| Upload | `/api/upload` | `upload/route.ts` |
| Documents | CRUD, bulk, reindex, labels, search, summarize, table-facts, signed-url | `documents/` |
| Ingestion | batches, jobs, retry, quality | `ingestion/` |
| Registry | records CRUD | `registry/records/` |
| Images | signed URLs | `images/[id]/signed-url/route.ts` |
| Ops | health, setup-status, local-project-id | `health/`, `setup-status/`, `local-project-id/` |
| Eval / jobs | eval cases, job state | `eval-cases/`, `jobs/` |
| Area | Routes | Entry files |
| ------------- | ------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------- |
| Answers | `/api/answer`, `/api/answer/stream`, `/api/answer-feedback` | `answer/route.ts`, `answer/stream/route.ts`, `answer-feedback/` |
| Search | `/api/search`, `/api/search/interaction`, `/api/search/universal` | `search/` |
| Upload | `/api/upload` | `upload/route.ts` |
| Documents | `/api/documents`, `/api/documents/[id]`, bulk/reindex, labels, reviews, search, signed URLs, summaries, table facts | `documents/` |
| Differentials | `/api/differentials`, `/api/differentials/[slug]`, `/api/differentials/presentations/[slug]` | `differentials/` |
| Medications | `/api/medications`, `/api/medications/[slug]` | `medications/` |
| Ingestion | `/api/ingestion/batches`, `/api/ingestion/jobs`, retry, quality | `ingestion/` |
| Registry | `/api/registry/records`, `/api/registry/records/[slug]` | `registry/records/` |
| Images | `/api/images/[id]/signed-url` | `images/[id]/signed-url/route.ts` |
| Ops | `/api/health`, `/api/health/ready`, `/api/setup-status`, `/api/local-project-id` | `health/`, `setup-status/`, `local-project-id/` |
| Eval / jobs | `/api/eval-cases`, `/api/jobs` | `eval-cases/`, `jobs/` |

---

Expand DownExpand Up@@ -151,12 +153,12 @@ Structured map for AI agents and onboarding. For live routes, see `docs/site-map

- **CLI:** `supabase/config.toml` — `indexing-v3-agent` function, `verify_jwt = false`
- **Schema mirror:** `supabase/schema.sql` (reference; migrations are source of truth)
- **Migrations:** `supabase/migrations/*.sql` (~90 files, May–Jul 2026)
- **Migrations:** `supabase/migrations/*.sql` (chronological source of truth; do not hardcode a count)
- **Drift policy:** `docs/supabase-migration-reconciliation.md`

### Core tables
### Schema tables

`documents`, `document_pages`, `document_images`, `document_chunks`, `document_embedding_fields`, `document_index_units`, `document_table_facts`, `document_labels`, `document_summaries`, `document_sections`, `document_memory_cards`, `document_index_quality`, `ingestion_jobs`, `ingestion_job_stages`, `indexing_v3_agent_jobs`, `import_batches`, `rag_queries`, `rag_query_misses`, `rag_aliases`, `rag_response_cache`, `rag_retrieval_logs`, `clinical_registry_records`, `api_rate_limits`, `audit_logs`, `storage_cleanup_jobs`
`documents`, `document_pages`, `document_images`, `document_chunks`, `document_embedding_fields`, `document_index_units`, `document_table_facts`, `document_labels`, `document_summaries`, `document_sections`, `document_memory_cards`, `document_index_quality`, `document_title_words`, `ingestion_jobs`, `ingestion_job_stages`, `indexing_v3_agent_jobs`, `import_batches`, `image_caption_cache`, `rag_queries`, `rag_query_misses`, `rag_aliases`, `rag_response_cache`, `rag_retrieval_logs`, `rag_visual_eval_cases`, `rag_visual_eval_runs`, `rag_answer_feedback`, `clinical_registry_records`, `clinical_registry_record_sources`, `medication_records`, `differential_records`, `source_review_events`, `api_rate_limits`, `api_rate_limit_subjects`, `audit_logs`, `storage_cleanup_jobs`

**Storage buckets:** `clinical-documents`, `clinical-images` (private)

Expand Down
13 changes: 7 additions & 6 deletions docs/site-map.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

This file is generated by `npm run sitemap:update`. Run `npm run sitemap:check` to verify it is current.

## Main product pages
## Main product routes

- `/` - Main Clinical KB shell. Source: `src/app/page.tsx`.
- `/differentials` - Differentials home and search surface. Source: `src/app/differentials/page.tsx`.
Expand DownExpand Up@@ -799,6 +799,11 @@ This file is generated by `npm run sitemap:update`. Run `npm run sitemap:check`
- `/mockups/universal-search-command` - Route discovered from app directory Source: `src/app/mockups/universal-search-command/page.tsx`.
- `/mockups/universal-search-redesign` - Route discovered from app directory Source: `src/app/mockups/universal-search-redesign/page.tsx`.

## Public utility route handlers

- `/auth/callback` - Authentication callback handler. Source: `src/app/auth/callback/route.ts`.
- `/icons/[variant]` - Dynamically generated application icon handler. Source: `src/app/icons/[variant]/route.tsx`.

## API routes

- `/api/answer` - Generate answer response. Source: `src/app/api/answer/route.ts`.
Expand DownExpand Up@@ -838,14 +843,10 @@ This file is generated by `npm run sitemap:update`. Run `npm run sitemap:check`
- `/api/setup-status` - Setup status. Source: `src/app/api/setup-status/route.ts`.
- `/api/upload` - Upload endpoint. Source: `src/app/api/upload/route.ts`.

## App route handlers

- `/auth/callback` - Route discovered from app directory Source: `src/app/auth/callback/route.ts`.

## Redirects

- `/applications` - Redirects to `/tools`. Source: `src/app/applications/route.ts`.
- `/differentials/presentations` - Redirects to `/differentials/presentations/[slug]`. Source: `src/app/differentials/presentations/route.ts`.
- `/differentials/presentations` - Redirects to `/differentials/presentations/[workflow-slug]`. Source: `src/app/differentials/presentations/route.ts`.
- `/documents/source` - Redirects to `/documents/search`. Source: `src/app/documents/source/page.tsx`.
- `/medications` - Redirects to `/?mode=prescribing`. Source: `src/app/medications/route.ts`.
- `/mockups/favourites-hub` - Redirects to `/favourites`. Source: `src/app/mockups/favourites-hub/page.tsx`.
Expand Down
1 change: 1 addition & 0 deletions playwright.config.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,6 +55,7 @@
grepInvert: mockupTag,
use: {
...devices["Desktop Chrome"],
reducedMotion: "no-preference",

Check failure on line 58 in playwright.config.ts

View workflow job for this annotation

GitHub Actions/ Static PR checks

No overload matches this call.

@coderabbitaicoderabbitaiBotJul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bashset -eu
rg -n '"(`@playwright/test`|playwright)"|reducedMotion|contextOptions' \
playwright.config.ts package.json package-lock.json pnpm-lock.yaml yarn.lock 2>/dev/null ||true

Repository: BigSimmo/Database

Length of output: 668

🏁 Script executed:

#!/bin/bashset -eu
printf'\n--- playwright.config.ts (excerpt) ---\n'
cat -n playwright.config.ts | sed -n '35,70p'printf'\n--- package.json Playwright entries ---\n'
cat -n package.json | sed -n '205,225p'printf'\n--- local Playwright docs/type hints if present ---\n'
fd -a 'contextOptions*|playwright*' node_modules/next/dist/docs node_modules 2>/dev/null | sed -n '1,80p'||true

Repository: BigSimmo/Database

Length of output: 4025

🏁 Script executed:

#!/bin/bashset -eu
printf'\n--- Playwright type references for reducedMotion/contextOptions ---\n'
rg -n "reducedMotion|contextOptions" node_modules/playwright node_modules/playwright-core -g '*.d.ts' -g '*.md' -g '*.js'| sed -n '1,200p'printf'\n--- Playwright test config type definitions around use options ---\n'
FILE="$(fd -a 'test.d.ts' node_modules/playwright node_modules/playwright-core | head -n 1)"echo"Using: $FILE"if [ -n"$FILE" ];then
rg -n "reducedMotion|contextOptions|PlaywrightTestOptions|UseOptions""$FILE"| sed -n '1,120p'fi

Repository: BigSimmo/Database

Length of output: 26293

🏁 Script executed:

#!/bin/bashset -eu
FILE="node_modules/playwright/types/test.d.ts"printf'\n--- PlaywrightTestOptions / use-option section ---\n'
rg -n "interface PlaywrightTestOptions|type PlaywrightTestOptions|reducedMotion\\?|contextOptions: BrowserContextOptions|BrowserContextOptions""$FILE"| sed -n '1,120p'printf'\n--- excerpt around contextOptions / reducedMotion references ---\n'fornin 7528 7532 7536 7540 7544 7548;do
sed -n "${n},$((n+20))p""$FILE"printf'\n---\n'doneprintf'\n--- BrowserContextOptions definition around reducedMotion ---\n'
FILE2="node_modules/playwright-core/types/types.d.ts"
line=$(rg -n "^export interface BrowserContextOptions""$FILE2"| head -n 1 | cut -d: -f1)if [ -n"${line:-}" ];then
sed -n "$((line-5)),$((line+120))p""$FILE2"| rg -n "reducedMotion|contextOptions|colorScheme|interface BrowserContextOptions" -n
fi

Repository: BigSimmo/Database

Length of output: 4831

Move reducedMotion into contextOptions. Playwright’s use schema exposes this setting under contextOptions; the top-level reducedMotion entry here doesn’t match the config type and blocks config type-checking.

🧰 Tools
🪛 GitHub Check: Static PR checks

[failure] 58-58:
No overload matches this call.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@playwright.config.ts` at line 58, Move the reducedMotion setting from the
top-level Playwright use configuration into the contextOptions object,
preserving its "no-preference" value so the configuration matches Playwright’s
typed schema.

Source: Linters/SAST tools

...(chromiumExecutablePath ? { launchOptions: { executablePath: chromiumExecutablePath } } : {}),
},
},
Expand Down
16 changes: 11 additions & 5 deletions scripts/check-github-action-pins.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { readdirSync, readFileSync } from "node:fs";
import { existsSync, readFileSync, readdirSync } from "node:fs";
import path from "node:path";
import { validateActionReference } from "./github-action-pins.mjs";
import { yamlBlock } from "./yaml-contract.mjs";
Expand All@@ -10,10 +10,16 @@ const failures = [];
const expectedSupabaseCliVersion = "2.108.0";
const expectedSupabaseCliVersionPattern = expectedSupabaseCliVersion.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");

for (const fileName of readdirSync(workflowDir)
.filter((name) => /\.ya?ml$/i.test(name))
.sort()) {
const filePath = path.join(workflowDir, fileName);
function discoverGitHubActionFiles(workflowRoot) {
const workflowDir = path.join(workflowRoot, ".github", "workflows");
if (!existsSync(workflowDir)) return [];
return readdirSync(workflowDir, { withFileTypes: true })
.filter((entry) => entry.isFile() && /\.ya?ml$/i.test(entry.name))
.map((entry) => path.join(workflowDir, entry.name));
}

for (const filePath of discoverGitHubActionFiles(process.cwd())) {
const fileName = path.relative(process.cwd(), filePath).replaceAll("\\", "/");
const lines = readFileSync(filePath, "utf8").split(/\r?\n/);

lines.forEach((line, index) => {
Expand Down
93 changes: 44 additions & 49 deletions scripts/generate-site-map.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ const appDir = path.join(process.cwd(), "src", "app");
const siteMapPath = path.join(process.cwd(), "docs", "site-map.md");
const medicationSlugs = ["acamprosate"] as const;

type RouteKind = "page" | "api";
type RouteKind = "page" | "handler";

type DiscoveredRoute = {
route: string;
Expand All@@ -31,14 +31,23 @@ type RedirectRoute = {

type SiteMapData = {
pageRoutes: DiscoveredRoute[];
publicRouteHandlers: DiscoveredRoute[];
apiRoutes: DiscoveredRoute[];
appRouteHandlers: DiscoveredRoute[];
redirects: RedirectRoute[];
nonRoutedMockupArtifacts: string[];
};

const productRouteHandlerPaths = new Set(["/applications", "/differentials/presentations", "/medications"]);

const documentedRedirectTargets: Record<string, string> = {
"/applications": "/tools",
"/differentials/presentations": "/differentials/presentations/[workflow-slug]",
"/medications": "/?mode=prescribing",
};

const routeDescriptions: Record<string, string> = {
"/": "Main Clinical KB shell.",
"/applications": "Legacy application launcher redirect to Tools.",
"/differentials": "Differentials home and search surface.",
"/differentials/diagnoses": "Diagnosis stream.",
"/differentials/diagnoses/[slug]": "Differential diagnosis detail.",
Expand DownExpand Up@@ -72,6 +81,11 @@ const routeDescriptions: Record<string, string> = {
"/specifiers/map": "Psychiatric specifier family map.",
};

const publicRouteHandlerDescriptions: Record<string, string> = {
"/auth/callback": "Authentication callback handler.",
"/icons/[variant]": "Dynamically generated application icon handler.",
};

const apiDescriptions: Record<string, string> = {
"/api/answer": "Generate answer response.",
"/api/answer/stream": "Streaming answer response.",
Expand DownExpand Up@@ -128,8 +142,16 @@ function routeSegment(segment: string) {
return segment;
}

function isApiRoute(route: string) {
return route === "/api" || route.startsWith("/api/");
}

function fileToRoute(filePath: string, kind: RouteKind) {
const suffix = kind === "page" ? "page.tsx" : "route.ts";
const suffix = path.basename(filePath);
const expectedSuffixes = kind === "page" ? ["page.tsx"] : ["route.ts", "route.tsx"];
if (!expectedSuffixes.includes(suffix)) {
throw new Error(`Unsupported ${kind} route file: ${filePath}`);
}
const relative = toPosixPath(path.relative(appDir, filePath));
const withoutFile = relative.slice(0, -suffix.length).replace(/\/$/, "");
const segments = withoutFile.split("/").filter(Boolean).map(routeSegment).filter(Boolean);
Expand All@@ -150,43 +172,22 @@ function collectFiles(root: string, targetFileName: string): string[] {
}

function discoverRoutes(kind: RouteKind): DiscoveredRoute[] {
const targetFile = kind === "page" ? "page.tsx" : "route.ts";
return collectFiles(appDir, targetFile)
const targetFiles = kind === "page" ? ["page.tsx"] : ["route.ts", "route.tsx"];
return targetFiles
.flatMap((targetFile) => collectFiles(appDir, targetFile))
.map((file) => ({
route: fileToRoute(file, kind),
file: toPosixPath(path.relative(process.cwd(), file)),
}))
.sort((left, right) => left.route.localeCompare(right.route) || left.file.localeCompare(right.file));
}

function isApiRoute(route: string) {
return route === "/api" || route.startsWith("/api/");
}

function extractRedirectTarget(source: string): string | null {
const pageRedirect = source.match(/\bredirect\(\s*["']([^"']+)["']\s*\)/)?.[1];
if (pageRedirect) return pageRedirect;

const urlRedirect = source.match(/NextResponse\.redirect\(\s*new URL\(\s*["']([^"']+)["']/)?.[1];
if (urlRedirect) return urlRedirect;

const pathnameRedirect = source.match(/\.pathname\s*=\s*["']([^"']+)["']/)?.[1];
if (pathnameRedirect) return pathnameRedirect;

// Template-literal destination builders with a stable route prefix.
const presentationsRedirect = source.match(/`(\/differentials\/presentations\/)\$\{/)?.[1];
if (presentationsRedirect && source.includes("NextResponse.redirect")) {
return `${presentationsRedirect}[slug]`;
}

return null;
}

function discoverRedirects(routes: DiscoveredRoute[]): RedirectRoute[] {
return routes
.map((route) => {
const source = readFileSync(path.join(process.cwd(), route.file), "utf8");
const target = extractRedirectTarget(source);
const target =
documentedRedirectTargets[route.route] ?? source.match(/\bredirect\(\s*["']([^"']+)["']\s*\)/)?.[1];
return target ? { ...route, target } : null;
})
.filter((value): value is RedirectRoute => Boolean(value))
Expand All@@ -203,20 +204,13 @@ function discoverNonRoutedMockupArtifacts() {

export function collectSiteMapData(): SiteMapData {
const pageRoutes = discoverRoutes("page");
const routeHandlers = discoverRoutes("api");
const apiRoutes = routeHandlers.filter((route) => isApiRoute(route.route));
const nonApiHandlers = routeHandlers.filter((route) => !isApiRoute(route.route));
const redirects = [...discoverRedirects(pageRoutes), ...discoverRedirects(nonApiHandlers)].sort(
(left, right) => left.route.localeCompare(right.route) || left.file.localeCompare(right.file),
);
const redirectRoutes = new Set(redirects.map((redirect) => redirect.route));
const appRouteHandlers = nonApiHandlers.filter((route) => !redirectRoutes.has(route.route));

const routeHandlers = discoverRoutes("handler");
const publicRouteHandlers = routeHandlers.filter((route) => !isApiRoute(route.route));
return {
pageRoutes,
apiRoutes,
appRouteHandlers,
redirects,
publicRouteHandlers,
apiRoutes: routeHandlers.filter((route) => isApiRoute(route.route)),
redirects: discoverRedirects([...pageRoutes, ...publicRouteHandlers]),
nonRoutedMockupArtifacts: discoverNonRoutedMockupArtifacts(),
};
}
Expand DownExpand Up@@ -397,14 +391,17 @@ function renderSiteMapRaw(data = collectSiteMapData()) {
].includes(route.route),
);
const mockupRoutes = data.pageRoutes.filter((route) => route.route.startsWith("/mockups"));
const publicUtilityRouteHandlers = data.publicRouteHandlers.filter(
(route) => !productRouteHandlerPaths.has(route.route),
);

const lines = [
"# Clinical KB Site Map",
"",
"This file is generated by `npm run sitemap:update`. Run `npm run sitemap:check` to verify it is current.",
"",
...section(
"Main product pages",
"Main product routes",
productRoutes.map((route) => routeLine(route, routeDescriptions)),
Comment on lines +394 to 405

@coderabbitaicoderabbitaiBotJul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Restore product redirect handlers to “Main product routes.”

The renderer drops product handlers from that section, and the regression test incorrectly codifies their absence.

  • scripts/generate-site-map.ts#L394-L405: append handlers in productRouteHandlerPaths to the main product route list.
  • scripts/generate-site-map.ts#L481-L484: continue excluding those product handlers from the utility-handler section.
  • tests/site-map.test.ts#L90-L97: change the product-section assertion to toContain.
📍 Affects 2 files
  • scripts/generate-site-map.ts#L394-L405 (this comment)
  • scripts/generate-site-map.ts#L481-L484
  • tests/site-map.test.ts#L90-L97
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/generate-site-map.ts` around lines 394 - 405, Restore product
redirect handlers to the “Main product routes” section by appending handlers
identified by productRouteHandlerPaths to the product route list used by the
sitemap renderer in scripts/generate-site-map.ts lines 394-405. Keep
scripts/generate-site-map.ts lines 481-484 excluding those handlers from the
utility-handler section. Update the product-section assertion in
tests/site-map.test.ts lines 90-97 from toNotContain to toContain.

),
...section("Mode/query routes", renderModeRoutes()),
Expand DownExpand Up@@ -481,23 +478,21 @@ function renderSiteMapRaw(data = collectSiteMapData()) {
]
: []),
]),
...section(
"Public utility route handlers",
publicUtilityRouteHandlers.map((route) => routeLine(route, publicRouteHandlerDescriptions)),
),
...section(
"API routes",
data.apiRoutes.map((route) => routeLine(route, apiDescriptions)),
),
...(data.appRouteHandlers.length
? section(
"App route handlers",
data.appRouteHandlers.map((route) => routeLine(route, routeDescriptions)),
)
: []),
...section(
"Redirects",
data.redirects.length
? data.redirects.map((redirect) =>
bullet(redirect.route, `Redirects to \`${redirect.target}\`. Source: \`${redirect.file}\`.`),
)
: ["- No redirects discovered."],
: ["- No page-level redirects discovered."],
),
...section("Known caveats and stale-path flags", [
"- `/mockups/*` prototype routes are development-only; production returns 404 and `robots.txt` disallows indexing.",
Expand Down
2 changes: 1 addition & 1 deletion src/app/layout.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import type { Metadata, Viewport } from "next";
import { Geist, Geist_Mono } from "next/font/google";
import { headers } from "next/headers";
import { PwaLifecycle } from "@/components/pwa-lifecycle";
import { AuthProvider } from "@/lib/supabase/client";
import { PwaLifecycle } from "@/components/pwa-lifecycle";
import { WebVitalsReporter } from "@/components/web-vitals-reporter";
import { resolveMetadataBase } from "@/lib/metadata-base";
import { APP_THEME_COLORS } from "@/lib/theme";
Expand Down
7 changes: 1 addition & 6 deletions src/app/page.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,12 +5,7 @@ import { HomePageClient } from "@/app/home-page-client";
import { appModeHomeHref, isAppModeId, isAppModeVisible, type AppModeId } from "@/lib/app-modes";

type HomeProps = {
searchParams?: Promise<{
mode?: string | string[];
q?: string | string[];
focus?: string | string[];
run?: string | string[];
}>;
searchParams?: Promise<Record<string, string | string[] | undefined>>;
};

function firstSearchParam(value: string | string[] | undefined) {
Expand Down
Loading
Loading