Skip to content

fix: resolve design-audit regression hardening for merge - #809

Closed
BigSimmo wants to merge 7 commits into
mainfrom
codex/main-merge-safe-final-20260718
Closed

fix: resolve design-audit regression hardening for merge#809
BigSimmo wants to merge 7 commits into
mainfrom
codex/main-merge-safe-final-20260718

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Jul 18, 2026

Copy link
Copy Markdown
Owner

This PR merges the final design-audit remediation stack plus Playwright typecheck fixes, including: reduced-motion Playwright config correction, regression test expectations stabilization, retrieval/supabase index schema updates, route and UI accessibility fixes, and provider-free verification improvements. Verified locally with focused regression tests, typecheck, and lint on the merged tip ahead of origin/main.

Summary by CodeRabbit

  • New Features

    • Improved service comparison with expandable review details, source confidence, and comparison panels.
    • Added smarter clinical query correction to improve search results for misspelled terms.
    • Improved cleanup and synchronization of searchable document content.
  • Bug Fixes

    • Improved search menu interactions and reduced unexpected dropdown behavior.
    • Enhanced mobile service-page scrolling so the search dock clears appropriately.
    • Updated forms messaging and source-status guidance for greater clarity.
  • Documentation

    • Refreshed API, product route, redirect, and schema documentation.
  • Accessibility

    • Updated reduced-motion browser behavior and accessibility coverage.

@supabase

supabaseBot commented Jul 18, 2026

Copy link
Copy Markdown

Updates to Preview Branch (codex/main-merge-safe-final-20260718) ↗︎

DeploymentsStatusUpdated
DatabaseSat, 18 Jul 2026 06:23:27 UTC
ServicesSat, 18 Jul 2026 06:23:27 UTC
APIsSat, 18 Jul 2026 06:23:27 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

TasksStatusUpdated
Configurations⚠️Sat, 18 Jul 2026 06:26:03 UTC
MigrationsSat, 18 Jul 2026 06:30:13 UTC
Seeding⏸️Sat, 18 Jul 2026 06:23:18 UTC
Edge Functions⏸️Sat, 18 Jul 2026 06:23:18 UTC

❌ Branch Error • Sat, 18 Jul 2026 06:30:13 UTC

failed to connect to postgres: failed to connect to `user=postgres database=postgres`:
[2406:da1c:10e4:6400:4a06:6337:914b:88da]:5432 (2406:da1c:10e4:6400:4a06:6337:914b:88da): dial error: timeout: context deadline exceeded
[2406:da1c:10e4:6400:4a06:6337:914b:88da]:5432 (2406:da1c:10e4:6400:4a06:6337:914b:88da): dial error: timeout: context deadline exceeded

⚠️ Warning — Service health check failed


View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@coderabbitai

coderabbitaiBot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 179b3feb-630a-4cf0-a9e3-d30a8b17b921

📥 Commits

Reviewing files that changed from the base of the PR and between 3b54a78 and 425366f.

📒 Files selected for processing (26)
  • docs/codebase-index.md
  • docs/site-map.md
  • playwright.config.ts
  • scripts/check-github-action-pins.mjs
  • scripts/generate-site-map.ts
  • src/app/layout.tsx
  • src/app/page.tsx
  • src/components/clinical-dashboard/master-search-header.tsx
  • src/components/forms/forms-home-page.tsx
  • src/components/services/services-navigator-page.tsx
  • src/lib/rag-candidate-sources.ts
  • src/lib/rag.ts
  • supabase/drift-manifest.json
  • supabase/migrations/20260714180000_patch_rag_and_corrector_scalability.sql
  • supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql
  • supabase/migrations/20260717010000_harden_rag_scalability_patch.sql
  • supabase/schema.sql
  • tests/audit-content-services-regressions.test.ts
  • tests/audit-navigation-auth-regressions.test.ts
  • tests/rag-variant-early-exit.test.ts
  • tests/site-map.test.ts
  • tests/supabase-schema.test.ts
  • tests/ui-accessibility.spec.ts
  • tests/ui-smoke.spec.ts
  • tests/ui-tools.spec.ts
  • tsconfig.json

📝 Walkthrough

Walkthrough

The PR updates sitemap generation and documentation, revises RAG retrieval and Supabase scalability logic, changes service and forms UI behavior, refreshes regression coverage, and adjusts browser, workflow, TypeScript, and application entrypoint configuration.

Changes

Routing and sitemap

Layer / File(s)Summary
Route discovery and rendering
scripts/generate-site-map.ts
Separates public utility handlers from API routes, updates redirect extraction, and renders revised sitemap sections.
Sitemap documentation and coverage
docs/site-map.md, tests/site-map.test.ts
Documents public handlers and validates route placement across product, API, and redirect sections.
Codebase index updates
docs/codebase-index.md
Expands documented API capabilities, migrations, and schema tables.

RAG retrieval and database scalability

Layer / File(s)Summary
Database functions and indexes
supabase/migrations/*, supabase/schema.sql, supabase/drift-manifest.json
Adds title-word synchronization, registry cleanup, trigram indexes, and hardened clinical query correction.
RPC and candidate retrieval execution
src/lib/rag-candidate-sources.ts
Uses direct RPC/query execution and removes explicit abort-signal parameters from candidate retrieval and hydration contracts.
RAG orchestration and abort behavior
src/lib/rag.ts
Updates classifier fallback, enrichment, visual evidence, coverage gating, and hybrid retrieval wiring.
Schema and retrieval validation
tests/supabase-schema.test.ts, tests/rag-variant-early-exit.test.ts
Validates migration SQL, permissions, cleanup behavior, correction probes, index parity, and retrieval table usage.

Interface behavior and service workflows

Layer / File(s)Summary
Search and forms interactions
src/components/clinical-dashboard/master-search-header.tsx, src/components/forms/forms-home-page.tsx
Changes mode-menu dismissal and updates forms task and expired-session content.
Service navigator controls and panels
src/components/services/services-navigator-page.tsx
Uses shared metrics and adds collapsible review, confidence, and comparison controls.
Interface regression coverage
tests/audit-content-services-regressions.test.ts, tests/audit-navigation-auth-regressions.test.ts, tests/ui-*.spec.ts
Refreshes UI contracts for forms, services, dashboard headings, mobile dock behavior, and service detail flows.

Tooling and application maintenance

Layer / File(s)Summary
Build and workflow tooling
scripts/check-github-action-pins.mjs, playwright.config.ts, tsconfig.json
Hardens workflow discovery, sets Chromium reduced-motion behavior, and excludes worktrees from TypeScript scanning.
Application entrypoint contracts
src/app/layout.tsx, src/app/page.tsx
Reorders imports and broadens the home-page search-parameter type.

Estimated code review effort: 5 (Critical) | ~120 minutes

Sequence Diagram(s)

sequenceDiagram
participant SearchPipeline
participant RAGCandidateSources
participant Supabase
SearchPipeline->>RAGCandidateSources: request candidate retrieval
RAGCandidateSources->>Supabase: execute versioned RPC or legacy fallback
Supabase-->>RAGCandidateSources: return candidates and hydration rows
RAGCandidateSources-->>SearchPipeline: return merged and ranked candidates
Loading

Possibly related PRs

Suggested reviewers:copilot, cursoragent, claude

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/main-merge-safe-final-20260718

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo