Web view improvements (update interval, settings) by ckcollab · Pull Request #286 · BitBotFactory/MikaLendingBot

ckcollab · 2017-03-31T19:51:48Z

Todo

Save settings to localStorage
Read settings from localStorage
Modal for settings
Gear icon
Add "years" to time views
~~Limit USD view to only show 2 decimal places~~ Believe this is being handed off to Total Account Holdings feature?

Description

This makes the page update every 10 seconds instead of every 30.

TESTING STAGE

Currently testing this for 24hrs

Types of changes

[~] New feature (non-breaking change which adds functionality)

Checklist:

I have read CONTRIBUTING.md
I fully understand Github Flow.
My code adheres to the code style of this project.
I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

rnevet · 2017-03-31T19:56:43Z

Why? The bot has a slow cycle.
How fast are you running the bot?

Since my bot is running at 1 min cycle, 30 sec is optimal for getting reasonable updates and not wasting bandwidth on mobile.

In any case, please make it configurable, I see 2 options:

Half of the bot sleep time. (The value needs to be passed in the json)
Using a URL parameter.

ckcollab · 2017-03-31T20:02:44Z

Interval ~10seconds -- I love watching the log flying around right after I make changes, etc. across all my coins (and their prices). I'm used to streaming output so I like it as up-to-date as possible :)

I mean, ideally it should be configurable based on preferences. I could add a button/slider/drop down to set this value?

rnevet · 2017-03-31T20:05:43Z

We have already some URL options.
It would be great to get a "settings" area if you can, otherwise another URL parameter should do it.

ckcollab · 2017-03-31T20:11:19Z

Oh. I wasn't even aware of the URL options! I skimmed over that in the docs.

...maybe I can add a nice little section for managing all of these options... :)

For my reference http://poloniexlendingbot.readthedocs.io/en/latest/configuration.html#lendingbot-html-options

rnevet · 2017-03-31T20:16:36Z

That would be great, never got to that.
Keep in mind that the page is mobile friendly.

rnevet · 2017-04-01T05:48:06Z

Just use prettyFloat instead of printFloat.

rnevet · 2017-04-02T10:13:45Z

Actually I would like the time views to be selectable by checkboxes in the settings as well, personally I would look at daily, monthly only.

rnevet · 2017-04-03T13:43:13Z

btw, I was working here to add "Total Account Value":
#246

rnevet · 2017-04-05T17:06:04Z

 if (currency == "BTC") {
 return displayUnit.formatValue(earnings) + " <span class=" + currencyClass + ">" + displayUnit.name + "</span> / " + name + "<br/>"
+ } else if (currency == "USD" || currency == "USDT") {
+ return printFloat(earnings, 2) + " <span class=" + currencyClass + ">" + currency + "</span> / "+ name + "<br/>";


I suggest we just use prettyFloat(earnings,2) instead of trying to guess which currency is a Fiat one.

i.e. I use EUR. ;)

That would change behavior for quite a few coins, I think we want to see Satoshi level resolution most of the times?

What other currencies should we add here? Some currencies may need special printing, in this case for USD it makes sense.

Also, the other currencies in this function use printFloat, you want to go in and change these to the style you prefer?

@ckcollab "EUR" for example and actually any currency supported by https://blockchain.info/api/exchange_rates_api
I'm thinking about using the prettyFloat as it will provide an accuracy of 2 decimals for any coin and I think that should be good enough, no? or should we make the accuracy configurable?
I'm open for suggestions.

Suggestion: I also add EUR, but maintain consistency with the surrounding code. Then in a separate PR we decide how to handle this particular problem.

rnevet · 2017-04-05T17:07:55Z

+ total_cell.innerHTML = "Total holdings";
+ total_cell = total_row.appendChild(document.createElement("th"));
+ total_cell.setAttribute("colspan", 2);
+ total_cell.innerHTML = prettyFloat(totalCoinsOverall, 2) + " USD";


USD? I guess it should be earningsOutputCoin

Since you're doing this in another PR I'll pull this stuff

rnevet · 2017-04-05T17:08:49Z

If you need a Gear icon you can use one from http://fontawesome.io/icons/

ckcollab · 2017-04-06T00:27:20Z

If you need a Gear icon you can use one from http://fontawesome.io/icons/

Just using the Bootstrap one, is fontawesome also included? Probably not necessary to have two icon libs when we only have the 1 page.

ckcollab · 2017-04-14T00:33:21Z

Gear icon looks out of place and a little lopsided.

Goahead and replace, I don't mind :)

Entering out of bounds values for refresh time are "saved" when an error should be shown.

Added a check for this.

Would you be willing to move the other web settings to this settings box?

I'd rather not, very very busy! Glad to share what little I could given I use this all the time, thanks for all the hard work!

rnevet · 2017-04-14T06:42:31Z

It is great! We will build upon. :)

Evanito · 2017-04-15T01:23:17Z

I move to merge in its current state, since I don't want to muck around with multiple branches while trying to change a single icon.
Thank you for your contribution!

@rnevet I leave final decision to you.

rnevet · 2017-04-15T06:51:20Z

@Evanito I've made the rest of the changes and minor fixes in this branch https://github.com/Mikadily/poloniexlendingbot/tree/web_setting. Made a PR back to @ckcollab and when he merges it, it should appear here. (Otherwise we can create a new PR from web_setting branch.)

Replace printFloat with prettyfloat for Fiat currencies (doesn't display .00)

…o get bad data set (sets localStorage without checking if it's valid)

As btcDisplayUnitsModes isn't a list of strings a simple indexOf won't match the mode.

new header with collapsing menu

rnevet · 2017-04-16T11:42:32Z

@yura-pakhuchiy can you test this as well?
@Evanito can you take a 2nd look?

yura-pakhuchiy · 2017-04-16T18:42:16Z

LGTM! I had exactly the same idea for settings dialog on webpage itself for quite some time. I have never found time to implement it. @ckcollab @rnevet Greak work!

Small things which can be improved:

Use 192 icon in navbar. It will look sharper on mobiles or if user zooms in on desktop.
Auto-collapse navbar after user clicked on settings. It is annoying a bit that navbar is still open after user closes settings dialog.

rnevet · 2017-04-16T21:02:52Z

@ckcollab Thanks!

ckcollab · 2017-04-16T22:04:22Z

@rnevet my pleasure, thanks for this project!

laxdog · 2017-05-03T06:00:15Z

Just saw these changes as I've been working on an old branch. They look really great. Nice work @ckcollab and @rnevet

ckcollab · 2017-05-03T06:27:47Z

Least I could do :)

Increase page update interval
bcb3be2

Evanito added the Queued label Mar 31, 2017

rnevet added Discussion NOT READY and removed Queued labels Mar 31, 2017

rnevet added the Enhancement label Mar 31, 2017

ckcollab added 2 commits March 31, 2017 15:07

show yearly earnings as well
de08e92

Display USD with 2 decimal places
1a58be0

ckcollab added 2 commits April 1, 2017 18:45

display total holdings
45bc439

fix grabbing totals when totalCoins not defined
d2aaf68

use max coins not total coins for total holdings
94b5f42

rnevet reviewed Apr 5, 2017
View reviewed changes

ckcollab changed the title ~~Increase page update interval~~Web view improvements (interval, settings)Apr 6, 2017

ckcollab changed the title ~~Web view improvements (interval, settings)~~Web view improvements (update interval, settings)Apr 6, 2017

ckcollab added 5 commits April 5, 2017 18:12

adds toastr and settings for interval + stats
30cd953

remove cruft
1b026fa

change "init" to "update" as it is ran multiple times
654c6ab

missed an init->update refactor
b5567c5

add EUR to nice currency printing
d1b4516

verify refresh rate value
4e087cb

Raanan Nevet added 8 commits April 14, 2017 18:55

new html header with collapsing menu
61081dd

restore default refreshrate to 30 seconds
24da4cd

added a version parameter to the javascript to force reload
ded06c3

added missing scheme in toastr urls
2e6cac4

rename loadSave to loadSettings
b97ab45

Added Bitcoin Display Unit to Settings.
5234536

Added OutputCurrencyDisplayMode to Settings.
a644a86

Added Effective Rate Calculation to Settings.
65fadef

rnevetand others added 5 commits April 15, 2017 13:21

Fix indentation issues
851c30e
Replace printFloat with prettyfloat for Fiat currencies (doesn't display .00)

refactor validating... will still behave weirdly if somehow manages t…
d18500e
…o get bad data set (sets localStorage without checking if it's valid)

Fixed indent issue
42294a3

Restored btcDisplayUnitsModes saving method
f98a4ab
As btcDisplayUnitsModes isn't a list of strings a simple indexOf won't match the mode.

Merge pull request#1from Mikadily/web_setting
d8fb51e
new header with collapsing menu

rnevet added 2 commits April 16, 2017 22:58

Close menu when settings is pressed.
52b6830

use icon192
b930c92

rnevet approved these changes Apr 16, 2017
View reviewed changes

rnevet merged commit c50f27b into BitBotFactory:masterApr 16, 2017

rnevet removed the In Progress label Apr 16, 2017

Evanito removed the Testing Phase label Apr 18, 2017

Uh oh!

Conversation

ckcollab commented Mar 31, 2017• edited by rnevet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Description

TESTING STAGE

Types of changes

Checklist:

Uh oh!

rnevet commented Mar 31, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ckcollab commented Mar 31, 2017

Uh oh!

rnevet commented Mar 31, 2017

Uh oh!

ckcollab commented Mar 31, 2017

Uh oh!

rnevet commented Mar 31, 2017

Uh oh!

rnevet commented Apr 1, 2017

Uh oh!

rnevet commented Apr 2, 2017

Uh oh!

rnevet commented Apr 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rnevetApr 5, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rnevet commented Apr 5, 2017

Uh oh!

ckcollab commented Apr 6, 2017

Uh oh!

ckcollab commented Apr 14, 2017

Uh oh!

rnevet commented Apr 14, 2017

Uh oh!

Evanito commented Apr 15, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rnevet commented Apr 15, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rnevet commented Apr 16, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yura-pakhuchiy commented Apr 16, 2017

Uh oh!

rnevet commented Apr 16, 2017

Uh oh!

ckcollab commented Apr 16, 2017

Uh oh!

laxdog commented May 3, 2017

Uh oh!

ckcollab commented May 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

ckcollab commented Mar 31, 2017•
edited by rnevet
Loading

rnevet commented Mar 31, 2017•
edited
Loading

rnevetApr 5, 2017•
edited
Loading

Evanito commented Apr 15, 2017•
edited
Loading

rnevet commented Apr 15, 2017•
edited
Loading

rnevet commented Apr 16, 2017•
edited
Loading