Uh oh!
There was an error while loading. Please reload this page.
[SDK] buildUnwrapCalldata + UnwrapERC7984 explain/verify - #9509
Open
0xPrabh wants to merge 1 commit into
Open
Conversation
Contributor
…/verify Encode unwrap(from, to, encryptedAmount, inputProof) for ERC-7984 unshield (selector 0x5bf4ef06), add UnwrapERC7984 tx type with builder classification, and verify self-directed unwrap calldata (from/to == wallet base address). Ticket: CHALO-1155 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
buildUnwrapCalldata(from, to, encryptedAmount, inputProof)andUnwrapERC7984transaction support for the ERC-7984 unshield path.unwrap(address,address,bytes32,bytes)with selector0x5bf4ef06from/to, 32-byteencryptedAmount, non-emptyinputProofTransactionType.UnwrapERC7984with builder +classifyTransactionmappingErc7984Token.verifyTransactionunwrap branch (direct + sendMultiSig); self-directedfrom == to == baseAddressgasLimit(WP owns gas)Issue Number
CHALO-1155
Parent: CHALO-1135
Type of change
How Has This Been Tested?
yarn workspace @bitgo/abstract-eth unit-test --grep "buildUnwrapCalldata|Method IDs"(13 passing)BITGOJS_TEST_PASSWORD=password yarn workspace @bitgo/sdk-coin-eth unit-test --grep "UnwrapERC7984|verifyTransaction – Unwrap"(12 passing)Checklist:
Made with Cursor