Skip to content

Some late feedback on 'Contribute to Guide' PR #109 - #118

Merged
johnsBeharry merged 53 commits into
masterfrom
ContributeToGuideTweaks
Jan 16, 2021
Merged

Some late feedback on 'Contribute to Guide' PR #109#118
johnsBeharry merged 53 commits into
masterfrom
ContributeToGuideTweaks

Conversation

@danielnordh

@danielnordhdanielnordh commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

I was too slow to comment on it before the merge but here are some tweaks.
Apart from fixed typos and some simplified language the main changes are:

  • Added Slack channel and Github sections on contribute.md
  • Suggest changing the nav title to 'Contribute to guide' to differentiate from higher level 'Contribute'
  • Bump sub-headline styling to differentiate do's/don't

@danielnordh

Copy link
Copy Markdown
ContributorAuthor

If/When this PR gets merged, please squash the commits as there it is a bit 'unclean', containing commits already merged.
Discussed this with @pavlenex and it seems to be the best way.

Reason: I branched off a PR that was already merged (unbeknownst to me). I then merged master into that branch to make sure there were no conflicts. But the previous commits still show up on this PR.

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, since this PR is based of my earlier PR and not the master, it would be a good idea to squash commits when merging this PR.

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly addressing the navigation and for all the improvements to the page.

Comment threadguide/contribute/contribute.md Outdated
Comment threadguide/contribute/contribute.md
Comment threadguide/contribute/contribute.md Outdated
danielnordhand others added 4 commits January 15, 2021 14:28
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
@johnsBeharry
johnsBeharry merged commit cda9e88 into masterJan 16, 2021
@danielnordh
danielnordh deleted the ContributeToGuideTweaks branch May 11, 2021 12:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@danielnordh@johnsBeharry@GBKS@pavlenex