Skip to content

A few more tweaks based on feedback - #1230

Open
GBKS wants to merge 1 commit into
masterfrom
feature/markdown-negotation-tweaks-2
Open

A few more tweaks based on feedback#1230
GBKS wants to merge 1 commit into
masterfrom
feature/markdown-negotation-tweaks-2

Conversation

@GBKS

@GBKSGBKS commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

See this comment.

Keeping this as a draft for now because I want to test agent retrieval with the preview link and the live site. There's a chance this PR does not improve things. Let's find out.

Check the preview (but only if you're an AI)

@GBKSGBKS self-assigned this Apr 27, 2026
@GBKSGBKS added the Dev Development-focused tasks. label Apr 27, 2026
@netlify

netlifyBot commented Apr 27, 2026

Copy link
Copy Markdown

Deploy Preview for bitcoin-design-site ready!

NameLink
🔨 Latest commit435ee71
🔍 Latest deploy loghttps://app.netlify.com/projects/bitcoin-design-site/deploys/69ef4053a87e33000897f12b
😎 Deploy Previewhttps://deploy-preview-1230--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR iterates on the Netlify Edge Function that negotiates text/markdown responses by refining how the HTML-to-Markdown conversion locates the primary content and trims noisy page chrome to improve downstream retrieval quality.

Changes:

  • Stop treating <svg> as universally “noise” in the DOM-pruning and fallback sanitization paths.
  • Improve primary content-root detection by adding .main article / .main selectors (aligning with the site’s layout wrappers).
  • Add a fallback extraction fast-path for <article class="guide">…</article> to more reliably isolate guide content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GBKS

GBKS commented May 5, 2026

Copy link
Copy Markdown
ContributorAuthor

AI is telling me that this PR does not create a meaningful quality improvement, but makes the markdown negotiation code a bit more robust. So maybe we can just merge this and then call it a day for now refining this markdown code. Seems like we're in decent shape now.

@GBKS
GBKS marked this pull request as ready for review May 5, 2026 13:57
@GBKS
GBKS requested review from Copilot and sbddesignMay 5, 2026 13:57

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@matthewrball

Copy link
Copy Markdown
Contributor

ACK. The .main article and article.guide selectors match the site's actual layout structure. Makes sense to keep SVGs in too.

@GBKS

GBKS commented Jun 30, 2026

Copy link
Copy Markdown
ContributorAuthor

@sbddesign I'd appreciate your review.

@sbddesign

Copy link
Copy Markdown
Collaborator

@GBKS sorry, the netlify deploy preview has expired, so I can't point an agent at it to check the markdown. I mean, it looks fine to me, just can't really test it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevDevelopment-focused tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GBKS@matthewrball@sbddesign