Skip to content

Adds multiple pages to the Onboarding chapter - #302

Merged
pavlenex merged 90 commits into
BitcoinDesign:masterfrom
ConorOkus:onboarding
May 24, 2021
Merged

Adds multiple pages to the Onboarding chapter#302
pavlenex merged 90 commits into
BitcoinDesign:masterfrom
ConorOkus:onboarding

Conversation

@ConorOkus

@ConorOkusConorOkus commented May 10, 2021

Copy link
Copy Markdown
Collaborator

Adds the following pages:

  • Backing up a recovery phrase
  • Restoring a wallet
  • Protecting a wallet
  • Restoring a wallet

Checkout the preview here

Closes the following issues:
#243
#242
#244

Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md
Comment threadguide/onboarding/protecting-a-wallet.md Outdated
Comment threadguide/onboarding/protecting-a-wallet.md
Comment threadguide/onboarding/backing-up-a-recovery-phrase.md Outdated

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, LGTM but overall!

Comment threadguide/onboarding/backing-up-a-recovery-phrase.md Outdated
Comment threadguide/onboarding/automatic-cloud-backup.md
Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/manual-backup.md Outdated
Comment threadguide/onboarding/manual-backup.md Outdated
Comment threadguide/onboarding/manual-backup.md Outdated

Lastly, another way to have a user confirm that they recorded their seed phrase correctly is by asking them to select (or manually type out) a random word from their seed phrase. For example, you would ask them to “type out word number 5”, or “type out word number 11”. To ensure maximum security, make sure you do this with 3-4 different words within their phrase. This design is less cumbersome for users, but might be a pain if they did not number their seed phrase.


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to the next page.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider adding a screen with a success message to the bottom. Just like the last screen in the image gallery on the automatic cloud backup page.

Comment threadguide/onboarding/protecting-a-wallet.md
Comment threadguide/onboarding/protecting-a-wallet.md Outdated
Comment threadguide/onboarding/protecting-a-wallet.md
@GBKSGBKS added the Copy Task is about improving text. label May 11, 2021
Bosch-0
Bosch-0 previously approved these changes May 12, 2021
Bosch-0
Bosch-0 previously approved these changes May 13, 2021

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the Onboarding section coming together. I've reviewed everything but the Protecting a wallet section since Connor mentioned he's pushing some changes from #112.

Comment threadguide/onboarding/backing-up-a-recovery-phrase.md Outdated
Comment threadguide/onboarding/backing-up-a-recovery-phrase.md Outdated
Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/automatic-cloud-backup.md Outdated
Comment threadguide/onboarding/manual-backup.md Outdated
Comment threadguide/onboarding/manual-backup.md Outdated
Comment threadguide/onboarding/manual-backup.md Outdated
Comment threadguide/onboarding/restoring-a-wallet.md Outdated
Comment threadguide/onboarding/restoring-a-wallet.md
@ConorOkusConorOkus changed the title WIP - Adds multiple pages to the Onboarding chapterAdds multiple pages to the Onboarding chapterMay 16, 2021
While this is an easier way for users to set up a wallet, it brings in the potential threat of malicious third-party access. If a user’s cloud account is hacked or they forget their cloud login information, their funds could be compromised.

Additionally, by bringing cloud storage providers into the equation, we assume that users trust their providers. This also raises the question of [decentralization]({{ 'guide/foundations/principles/#decentralization' | relative_url }}): a guiding principle of the bitcoin space and could be considered at conflict with the popular saying, “not your keys, not your coins”.
By bringing cloud storage providers into the equation, we assume that users trust their providers. This also raises the question of [decentralization]({{ 'guide/foundations/principles/#decentralization' | relative_url }}): a guiding principle of the Bitcoin space and could be considered in conflict with the popular saying, “not your keys, not your coins”.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know photon is kind of on hold but could it recommended to designers to integrate some kind of encryption on the data stored in the cloud? Ideally by a users entered PIN as that is much harder to forgot than a passphrase.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the gallery image to use PIN-based auth 👍

Bosch-0
Bosch-0 previously approved these changes May 23, 2021
pavlenex
pavlenex previously approved these changes May 24, 2021

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just saw we don't use pros/cons visually consistent, so added suggestions for those.

Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Comment threadguide/onboarding/funding-a-wallet.md Outdated
Co-authored-by: Pavlenex <pavle@pavle.org>
Conor Okusand others added 5 commits May 24, 2021 15:25
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
pavlenex
pavlenex previously approved these changes May 24, 2021
Comment threadguide/onboarding/funding-a-wallet.md Outdated
@pavlenex
pavlenex dismissed stale reviews from themself via f3c73d3May 24, 2021 12:16
Comment threadguide/onboarding/funding-a-wallet.md Outdated

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as previously agreed as the PR is quite big and critical for us to proceed on other PR's. I've pushed a fix for formatting in 85bf62e, which was my bad when adding a suggestion.

Great work. Let's address any minor stuff (if any) in smaller PR's in the future. 🚀 🚀 🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CopyTask is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ConorOkus@pavlenex@GBKS@sbddesign@Bosch-0