Skip to content

Added ⚡ content to Getting Started > Hardware overview - #476

Merged
GBKS merged 14 commits into
BitcoinDesign:masterfrom
Bosch-0:hardware_overview
Sep 20, 2021
Merged

Added ⚡ content to Getting Started > Hardware overview#476
GBKS merged 14 commits into
BitcoinDesign:masterfrom
Bosch-0:hardware_overview

Conversation

@Bosch-0

@Bosch-0Bosch-0 commented Sep 16, 2021•
edited by GBKS
Loading

Copy link
Copy Markdown
Collaborator

Adding Lightning content to the hardware overview page, solves #466

Deploy: https://deploy-preview-476--sad-borg-390916.netlify.app/guide/getting-started/hardware/

GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 16, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
@GBKS

GBKS commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Looks great, this is a good revision. Just had a few minor nit-picky things, after that I think it's ready to go.

Bosch-0and others added 8 commits September 17, 2021 09:03
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
0ce2587
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
14c6ca8
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
a60ce70
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
cc3bb2c
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
14ee69a
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
07db5a2
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
4f9933f
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
9c17e07
Co-authored-by: Christoph Ono <chri@sto.ph>
Bosch-0
Bosch-0 commented Sep 17, 2021
View reviewed changes

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that :)

@GBKSGBKS added the Copy Task is about improving text. label Sep 17, 2021
@GBKSGBKS added this to the Milestone #7 milestone Sep 17, 2021
@GBKSGBKS linked an issue Sep 17, 2021 that may be closed by this pull request
Add ⚡️ content to Getting Started > Hardware overview#466
Closed
GBKS
GBKS reviewed Sep 17, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 17, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 17, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS reviewed Sep 17, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md
GBKS
GBKS reviewed Sep 17, 2021
View reviewed changes
Comment threadguide/getting-started/hardware.md Outdated
GBKS
GBKS requested changes Sep 17, 2021
View reviewed changes

@GBKSGBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few super minor tweaks after reading through the page again. Otherwise, ready to go.

@danielnordhdanielnordh mentioned this pull request Sep 17, 2021
Closed
46 tasks
pavlenex
pavlenex reviewed Sep 17, 2021
View reviewed changes

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Bosch-0, comparing it to the previous page, you managed to iron out quite a few things. I only have two concerns:

  • A claim that a hardware wallet cannot leak sensitive data in one of the paragraphs, the paragraph explains this more accurately.
  • A claim that you can run a lightning node on a smatphone, I am not really sure about this at this stage.

Comment threadguide/getting-started/hardware.md Outdated
Comment threadguide/getting-started/hardware.md
Bosch-0and others added 5 commits September 20, 2021 18:31
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
efe94dc
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
878288c
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
b47d745
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@GBKS
Update guide/getting-started/hardware.md
9790bb3
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0@pavlenex
Update guide/getting-started/hardware.md
f6ab44f
Co-authored-by: Pavlenex <pavle@pavle.org>
@pavlenex

pavlenex commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

@GBKS review and approve, can't merge since the request a change is blocking it

GBKS
GBKS approved these changes Sep 20, 2021
View reviewed changes

@GBKSGBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the feedback. Looks really good.

@GBKS
GBKS merged commit 0f19893 into BitcoinDesign:masterSep 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GBKSGBKSGBKS approved these changes
+1 more reviewer
@pavlenexpavlenexpavlenex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Bosch-0Bosch-0

Labels

CopyTask is about improving text.

Projects

None yet

Milestone

Milestone #7

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Getting Started > Hardware overview

3 participants

@Bosch-0@GBKS@pavlenex