Skip to content

Adding ⚡️ content to Designing Bitcoin Products > Personal Finance - #512

Merged
pavlenex merged 17 commits into
BitcoinDesign:masterfrom
sbddesign:feature/personal-finance-lightning-updates
Oct 19, 2021
Merged

Adding ⚡️ content to Designing Bitcoin Products > Personal Finance#512
pavlenex merged 17 commits into
BitcoinDesign:masterfrom
sbddesign:feature/personal-finance-lightning-updates

Conversation

@sbddesign

@sbddesignsbddesign commented Oct 9, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Lightning content added to Personal Finance page.
⚡️ See Deploy Preview

  • I turned the daily spending wallet into a mobile LN wallet
  • I briefly talk about the disadvantages of not using LN for monthly budgeting, and how security hardening will change this in the future
    • My thinking is that it may be good to let technologies like Lightning Signer grow a little bit before making precise claims in the Guide about what a security-hardened Lightning node would be like from a user-perspective.
  • Did various tweaks here and there.

@GBKSGBKS added Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section. labels Oct 11, 2021
@GBKSGBKS added this to the Milestone #8 milestone Oct 11, 2021
Bosch-0
Bosch-0 previously approved these changes Oct 11, 2021
View reviewed changes

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@danielnordhdanielnordh mentioned this pull request Oct 11, 2021
Closed
46 tasks
@sbddesign
sbddesign marked this pull request as ready for review October 12, 2021 21:50
johnsBeharry
johnsBeharry previously approved these changes Oct 12, 2021
View reviewed changes

@johnsBeharryjohnsBeharry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadguide/designing-products/personal-finance.md Outdated
Comment threadguide/designing-products/personal-finance.md Outdated
Bosch-0
Bosch-0 reviewed Oct 13, 2021
View reviewed changes
Comment threadguide/designing-products/personal-finance.md Outdated
Bosch-0
Bosch-0 reviewed Oct 13, 2021
View reviewed changes

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one comment

Stephen DeLormeand others added 2 commits October 13, 2021 09:42
Stephen DeLorme@Bosch-0
Update guide/designing-products/personal-finance.md
889f4c5
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
@sbddesign
Grammar fix
16c44b1
@sbddesign

sbddesign commented Oct 13, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Looks good, only one comment

Thanks @Bosch-0 ! I committed your suggestion and then tweaked the grammar slightly. I think the idea may be better expressed as a parenthetical.

Stephen DeLorme@johnsBeharry
Update guide/designing-products/personal-finance.md
fecb19e
Co-authored-by: Johns Beharry <johns@peakshift.com>
Bosch-0
Bosch-0 previously approved these changes Oct 15, 2021
View reviewed changes
GBKS
GBKS requested changes Oct 15, 2021
View reviewed changes

@GBKSGBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, just had a few minor comments (as always :)).

Comment threadguide/designing-products/personal-finance.md Outdated
Comment threadguide/designing-products/personal-finance.md Outdated
Comment threadguide/designing-products/personal-finance.md Outdated
Comment threadguide/designing-products/personal-finance.md
Comment threadguide/designing-products/personal-finance.md Outdated
@sbddesignsbddesign mentioned this pull request Oct 15, 2021
Closed
pavlenex
pavlenex previously approved these changes Oct 18, 2021
View reviewed changes
Comment threadguide/designing-products/personal-finance.md Outdated
@pavlenex

pavlenex commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

@GBKS requires your approval. My uppercase be can be committed directly so we can merge this one in.

@pavlenex
pavlenex requested a review from GBKSOctober 18, 2021 09:15
Stephen DeLorme@pavlenex
Update guide/designing-products/personal-finance.md
28a476f
Co-authored-by: Pavlenex <pavle@pavle.org>
GBKS
GBKS previously approved these changes Oct 19, 2021
View reviewed changes

@GBKSGBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent-e! Ready to go.

Only thing to tweak would be to properly capitalize Bitcoin when the network is referenced, and not the currency (4th paragraph).

pavlenex
pavlenex previously approved these changes Oct 19, 2021
View reviewed changes
@pavlenex
pavlenex dismissed stale reviews from GBKS and themself via 209dcc2October 19, 2021 09:00
@pavlenex
pavlenex merged commit 8848299 into BitcoinDesign:masterOct 19, 2021
@pavlenexpavlenex mentioned this pull request Oct 19, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsBeharryjohnsBeharryjohnsBeharry left review comments
@GBKSGBKSGBKS left review comments
+2 more reviewers
@pavlenexpavlenexpavlenex approved these changes
@Bosch-0Bosch-0Bosch-0 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sbddesignsbddesign

Labels

CopyTask is about improving text.Design bitcoin productsReferring to the Design BTC product section.

Projects

None yet

Milestone

Milestone #8

Development

Successfully merging this pull request may close these issues.

5 participants

@sbddesign@pavlenex@johnsBeharry@GBKS@Bosch-0