Update ⚡️Onboarding - Create a wallet --> First use, for Lightning by danielnordh · Pull Request #525 · BitcoinDesign/Guide

danielnordh · 2021-10-14T11:35:26Z

As described in #515, updates for Lightning.
Major changes:

Rename page (including file and permalink) to: First use (first-use)
Update links to work with new name/permalink (images not renamed)
Add 'First use' intro paragraph.
Shorten 'Create a wallet'
Readability tweaks

Note
Due to the filename/permalink change, other PR's may be affected when merging

Preview: https://deploy-preview-525--sad-borg-390916.netlify.app/guide/onboarding/first-use/

GBKS

Looking good 😎 Just a couple of minor recommendations.

I wonder if we need to revise the carousel info at the bottom. For example, the last one about face detection could have an actual button on the screen to enable Face ID. We could also add another screen for initiating the first deposit or purchase (thinking of the mock-ups @sbddesign did for the Phoenix review). That could be a new issue/PR.

Co-authored-by: Christoph Ono <chri@sto.ph>

sbddesign · 2021-10-15T16:30:57Z

I wonder if we need to revise the carousel info at the bottom. For example, the last one about face detection could have an actual button on the screen to enable Face ID. We could also add another screen for initiating the first deposit or purchase (thinking of the mock-ups @sbddesign did for the Phoenix review). That could be a new issue/PR.

@GBKS I like the idea of including something like my Phoenix mock-up as it pertains to a LN wallet and forming the first channel. Would that be better suited for the Funding a Wallet page?

sbddesign

I know this branch needs to merge in some upstream changes, but otherwise, LGTM @danielnordh 🎉

pavlenex

Agreed with adding Phoenix's mockups to Funding. I resolved the conflicts and this one only needs @GBKS approval for merge.

Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>

GBKS

The latest update from the main branch reverted changes Bosch made when he moved "Getting to know your users" from "Onboarding" to "Designing Bitcoin products".

"Getting to know your users" is back in the section overview page
"First use" is now the second page in the section - it should be the first
The "Creating a new wallet" button on the Onboarding section overview page is a dead link
The next button on "Getting to know your users" links now to a different section
...

Not listing it all as there's a bunch of stuff broken now. Please review that latest merge and fix things as required.

Also, once #529 is merged, we can set up the redirect for this page, so old links don't go into nowhere.

pavlenex · 2021-10-18T12:45:26Z

@GBKS are you referring to this commit e96ad5a?

GBKS · 2021-10-18T12:45:47Z

@sbddesign I don't think we need to add the full "first transaction" flow here, but we can show simple examples of extending onboarding beyond static content to include basic settings choices and interactive flows (if they are important for the first use). The "Funding a wallet" page can then cover all the details.

GBKS · 2021-10-18T12:47:17Z

@pavlenex that looks like the right one.

…ightning" This reverts commit e96ad5a, reversing changes made to 8d2b0ae.

pavlenex · 2021-10-18T12:50:00Z

I can try to revert it. I'm not sure why it wouldn't merge Bosch's changes. Will see what I did there that may have caused this.

pavlenex · 2021-10-18T12:58:39Z

I reverted the changes and it's now showing there are no conflicts and that they are even 😕

But it's not even as changes you've mentioned @GBKS are still not there.

@johnsBeharry any idea how we can rebase this one with master?

pavlenex · 2021-10-18T13:09:31Z

Okay, I realised what the error is. I've selected all commits but the one Bosch did, I am not sure how this happened, could be fat-finger error. Will try to fix it manually now.

danielnordh · 2021-10-19T08:03:07Z

Closing this PR as it was replaced by #531

PR #525 renamed the "Creating a wallet" page to "First use" and changed the URL. For that PR, the Jekyll redirect plugin was not available. Now it is, so here's a fix to ensure old links properly redirect to the new page.

danielnordh added 6 commits October 14, 2021 12:09

Add 'First use' intro, update 'Create a wallet'
6d547e4

Add Lightning paragraph
91fa353

Minor readability tweaks
3384758

Update name of page, permalink and mentions on other pages
c4ec8ff

Rename file
564c40f

Minor readability tweaks.
278a42d

danielnordh requested review from ConorOkus and pavlenex October 14, 2021 11:37

danielnordh mentioned this pull request Oct 14, 2021
⚡️ Add Lightning to the guide - Progress overview #478
Closed
46 tasks

GBKS assigned danielnordh Oct 15, 2021

GBKS added Copy Task is about improving text. Onboarding labels Oct 15, 2021

GBKS added this to the Milestone #9 milestone Oct 15, 2021

GBKS requested changes Oct 15, 2021
View reviewed changes

Comment threadguide/onboarding/first-use.md Outdated
Comment threadguide/onboarding/first-use.md Outdated
Comment threadguide/onboarding/first-use.md Outdated

GBKS linked an issue Oct 15, 2021 that may be closed by this pull request
Add ⚡️ content to Onboarding > Creating a new wallet#515
Closed

danielnordhand others added 3 commits October 15, 2021 15:01

Update wording
91cc6c8
Co-authored-by: Christoph Ono <chri@sto.ph>

Minor tweaks
f3e3696
Co-authored-by: Christoph Ono <chri@sto.ph>

Add comma
8d2b0ae
Co-authored-by: Christoph Ono <chri@sto.ph>

sbddesign reviewed Oct 15, 2021
View reviewed changes

Comment threadguide/onboarding/first-use.md Outdated

sbddesign reviewed Oct 15, 2021
View reviewed changes

Merge branch 'master' into feature/onboarding-create-wallet-lightning
e96ad5a

pavlenex previously approved these changes Oct 18, 2021
View reviewed changes

pavlenex requested a review from GBKS October 18, 2021 09:15

custody -> custodial
96d5eb6
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>

danielnordh dismissed stale reviews from pavlenex via 96d5eb6October 18, 2021 10:27

GBKS requested changes Oct 18, 2021
View reviewed changes

Revert "Merge branch 'master' into feature/onboarding-create-wallet-l…
bf64405
…ightning" This reverts commit e96ad5a, reversing changes made to 8d2b0ae.

GBKS mentioned this pull request Oct 18, 2021
Expand on onboarding carousel on the "First use" page #530
Closed

danielnordh mentioned this pull request Oct 18, 2021
Fix/pr525 - Update ⚡️Onboarding - Create a wallet --> First use, for Lightning #531
Merged

danielnordh marked this pull request as draft October 18, 2021 13:36

danielnordh closed this Oct 19, 2021

GBKS mentioned this pull request Oct 19, 2021
Follow up redirect fix for "First use" page PR #533
Merged

danielnordh deleted the feature/onboarding-create-wallet-lightning branch December 2, 2021 11:17

Uh oh!

Conversation

danielnordh commented Oct 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GBKS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbddesign commented Oct 15, 2021

Uh oh!

sbddesign left a comment

Choose a reason for hiding this comment

Uh oh!

pavlenex left a comment

Choose a reason for hiding this comment

Uh oh!

GBKS left a comment

Choose a reason for hiding this comment

Uh oh!

pavlenex commented Oct 18, 2021

Uh oh!

GBKS commented Oct 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GBKS commented Oct 18, 2021

Uh oh!

pavlenex commented Oct 18, 2021

Uh oh!

pavlenex commented Oct 18, 2021

Uh oh!

pavlenex commented Oct 18, 2021

Uh oh!

danielnordh commented Oct 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danielnordh commented Oct 14, 2021•
edited
Loading

GBKS commented Oct 18, 2021•
edited
Loading