Skip to content

Added ⚡️ content to Payments > Transactions - #593

Merged
GBKS merged 13 commits into
BitcoinDesign:masterfrom
sbddesign:feature/transactions-lightning
Dec 22, 2021
Merged

Added ⚡️ content to Payments > Transactions#593
GBKS merged 13 commits into
BitcoinDesign:masterfrom
sbddesign:feature/transactions-lightning

Conversation

@sbddesign

@sbddesignsbddesign commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator

I added LN content to the Payments > Transactions page.

See Deploy Preview

Fix for #571

pavlenex
pavlenex previously approved these changes Dec 13, 2021

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@sbddesignsbddesign self-assigned this Dec 13, 2021
@sbddesignsbddesign added Copy Task is about improving text. Design Task is about designing something. payments labels Dec 13, 2021
Comment threadguide/payments/transactions.md Outdated
Comment threadguide/payments/transactions.md Outdated
Comment threadguide/payments/transactions.md Outdated

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes but LGTM!

Comment threadguide/payments/transactions.md Outdated
Let's lay out the entire payment process.
| Bitcoin | Lightning |
|-------------|------------------|
| Users send *[transactions]({{'/guide/glossary/#transaction' | relative_url}})*. | Users send *[payments]({{'/guide/glossary/#payment' | relative_url}})*. |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it super unintuitive to distinguish transactions and payments by which layer they are on. To me, those words mean 95% the same thing. A distinction I could see being made is that a transaction is the technical thing that happens, while a payment is the thing users make.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially weird since the section is called Payments. The tech primer also uses the term transactions when referring to Lightning.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, could just remove the first line and change this section name to Comparing Bitcoin and Lightning payments.

Could distinguish how Bitcoin is more a settlement layer where as Lightning is more for P2P payments.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a Slack discussion about this point.

Let me summarize briefly what I was trying to convey in that thread. Consider this: "Alice pays Bob". We could provide two different descriptions of what is happening in that sentence. One is the user experience description. The other is the technical description. For the UX description, I feel comfortable using the terms payment and transaction interchangeably. However, for the tech description, the 2 terms should not be used interchangeably. They are very different concepts.

In this Figma file, I have tried to lay out the differences visually.

Since this page is providing more of a technical overview, I think it might be a good idea to use tech descriptions and not UX descriptions.

I tried to update and make this idea a little more clear in 513973c.

Thoughts?

@GBKSGBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Had some minor capitalization feedback. The reason why I requested changes is that I think the differentiation between transactions and payments is really fuzzy and not consistent with how we've used those terms elsewhere. Would be sweet to clear that up.

Comment threadguide/payments/transactions.md Outdated
Comment threadguide/payments/transactions.md Outdated
Comment threadguide/payments/transactions.md Outdated
Comment threadguide/payments/transactions.md Outdated
@pavlenexpavlenex linked an issue Dec 16, 2021 that may be closed by this pull request
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Stephen DeLormeand others added 9 commits December 20, 2021 11:02
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Comment threadguide/payments/transactions.md Outdated

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from me

@pavlenexpavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the changes.

@GBKS Needs your approval and let's get this one merged 🚀

This is radically different from the traditional financial system, where it is often possible for others to pull and withdraw money from your account (utility companies, financial institutions, merchants, etc.). When you make a payment, it will pass through systems that might delay, control or block the payment.

## Transaction lifecycle
{% include tip/open.html color="blue" icon="info" label="A note about terminology" %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this note ❤️

@GBKSGBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Looks great. It's really easy to read and follow along. Thanks for accommodating my request around the terminology.

@GBKS
GBKS merged commit a9b1633 into BitcoinDesign:masterDec 22, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CopyTask is about improving text.DesignTask is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Payments > Transactions

4 participants

@sbddesign@GBKS@pavlenex@Bosch-0