Restructured Payments chapter.

[Bosch-0]

Closes#596

Re structured the payments pages based on the above issue. I found the payment requests formats page to make more sense as a sub-page for the requesting bitcoin page, what do you think @GBKS?

1. This is requesting flows.
2. This is the types of requests that can be used.
3. This is how to send to those formats.

I found this order flowed smoother.

Preview

[GBKS]

Thanks for addressing this.

Do you think the Payment request formats page is necessary for readers to understand the Requesting bitcoin and Sending bitcoin pages? If not, then it's complementary and I think it could be well places towards the end of the section, after `Transaction overview´.

Should Transaction overview´ maybe be Transaction lifecycle´?

Make sure add redirect_from meta info to pages in which you change the permalink. I think there can be multiple entries if a page is moved multiple times.

I could also see us create a Receiving bitcoin page and split out that content to give it the space it needs so we can cover it in detail (different PR though).

[Bosch-0]

Do you think the Payment request formats page is necessary for readers to understand the Requesting bitcoin and Sending bitcoin pages?

I think it adds context to both pages and makes it clearer what kind of things are possible, I don't think you need to understand them all to grasp those pages but it gives a clearer picture.

Should Transaction overview´ maybe be Transaction lifecycle´?

I prefer overview as it essentially covers more than one lifecycle (on-chain + Lightning)

I could also see us create a Receiving bitcoin page and split out that content to give it the space it needs so we can cover it in detail (different PR though).

Yeah agree, we may want to go more in-depth with LSP stuff here to as that is where they come in to play.

[GBKS]

Looks great now. Just had two nitpicks about adding redirects for pages where the URL changed.

[sbddesign]

Thanks, looking good. I don't think I closely followed previous discussions about re-organizing the payments section, but I have no strong opinions about it. The new structure seems reasonable to me.

I left several grammatical, stylistic, and typographical edits. As usual, some of them are grammatically necessary and some are just my opinion on writing style.

[sbddesign]

Nit -- did you intend to include an illustration source file here? All I see is the surrounding comment tag.

[Bosch-0]

I just got in a habit of adding that there, not sure where the file is for that header @GBKS did you do this one?

[GBKS]

@johnsBeharry did that one.

[GBKS]

ACK. Ready to go. Thank you for working through this.

[pavlenex]

@sbddesign Requires your approval so we can merge it in.

[sbddesign]

Thanks for the edits, LGTM! 💯