Uh oh!
There was an error while loading. Please reload this page.
Updated Lightning service provider page - #809
Conversation
pavlenex
commented
May 10, 2022
Very hard to review when you rename things, as then the diffs show like everything is new, which will slow down things a bit. I suggest we split the rename + changes into two PR's for easier reviewing next time, nevertheless, I'm happy to dive deep into this one and review it as it is. |
Bosch-0
commented
May 10, 2022
It's pretty much a whole new page so the whole thing needs a review |
pavlenex
commented
May 10, 2022
Alright Sir, in that case I'm on it 🔎 |
pavlenex
left a comment
There was a problem hiding this comment.
A few nits, but overall this content has come a long way. Graphics are fantastic addition in explaining the concept, and I think you did great job simplifying very complex and abstract concepts, great job Bosch!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
pavlenex
left a comment
There was a problem hiding this comment.
There's an img conflict that needs to be resolved, but otherwise the page looks good to me.
sbddesign
left a comment
There was a problem hiding this comment.
Looking very nice! I left lots of grammar and style edits.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Bosch-0
commented
May 13, 2022
Thanks a bunch @sbddesign and @pavlenex , loads of great suggestions. Fixing up some of the bigger changes in my local copy today and will push them for a final update. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bosch-0
commented
May 16, 2022
Feedback has been addressed |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sbddesign
commented
May 16, 2022
@Bosch-0 Thanks for updating, I found a couple of other grammar issues and noted them above. |
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Closes#744
Made a bunch of updates to this page:
As this page is quite long now with the graphics, we could have two pages, one for LSPs and one for LWSs - thoughts?
💻 Live preview