Skip to content

Adds a page about accessibility to the designing bitcoin products section - #821

Merged
Bosch-0 merged 17 commits into
masterfrom
feature/new-accessibility-page
Jun 3, 2022
Merged

Adds a page about accessibility to the designing bitcoin products section#821
Bosch-0 merged 17 commits into
masterfrom
feature/new-accessibility-page

Conversation

@GBKS

@GBKSGBKS commented May 19, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds general information about the importance of accessibility, practical tips to get started, and some useful resources.

🙉Check the preview🥸

Closes#754.

@GBKS
Adds an accessibility page to designing bitcoin products
ad89b9f
This is currently still a work in progress.
@GBKSGBKS added Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section. labels May 19, 2022
@mouxdesign

mouxdesign commented May 19, 2022

Copy link
Copy Markdown
Collaborator

Add as assignee

@GBKSGBKS assigned GBKS and mouxdesign and unassigned GBKSMay 19, 2022
GBKSand others added 6 commits May 19, 2022 12:25
@GBKS
Added a caption
3b5a7ea
Just to show how to make commits.
@mouxdesign
Updated caption on Accessability page
599a485
Small edit to test.
@mouxdesign
Updated disability types
30fbd44
1) Updated explanations of disability types and included links to statistics.
2) Added in a link on how to test your apps accessibility.
@GBKS
Minor copy refinements
3a2019e
Tried to edit for clarity.
Added and updated some links.
@mouxdesign
Added Literacy paragraph + minor changes
e78cf50
1) Updated correct link to quadriplegic using phone
2) Changed heading to "Categories of accessibility needs"
3) Added paragraph about Illiteracy
4$ Added statistic source link to Hearing paragraph
@mouxdesign
Merge branch 'feature/new-accessibility-page' ofhttps://github.com/B…
16c01f8
…itcoinDesign/Guide into feature/new-accessibility-page
sbddesign
sbddesign requested changes May 22, 2022
View reviewed changes

@sbddesignsbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a lot of grammar and style edits. Also suggesting we add a modal option to the example image carousels.

Comment threadguide/designing-products/accessibility.md Outdated
Comment threadguide/designing-products/accessibility.md Outdated
Comment threadguide/designing-products/accessibility.md Outdated
Comment threadguide/designing-products/accessibility.md Outdated
Comment threadguide/designing-products/accessibility.md Outdated
Comment threadguide/designing-products/accessibility.md Outdated
Comment threadguide/designing-products/accessibility.md
Comment threadguide/designing-products/accessibility.md
@sbddesign

sbddesign commented May 22, 2022

Copy link
Copy Markdown
Collaborator

Just realized this was in draft mode. Sorry for providing such hyper-detailed feedback early when you may not have been ready for it.

mouxdesignand others added 6 commits May 23, 2022 08:32
@mouxdesignStephen DeLorme
Update guide/designing-products/accessibility.md
7331c95
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@mouxdesignStephen DeLorme
Update guide/designing-products/accessibility.md
e2dc8c5
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@mouxdesignStephen DeLorme
Update guide/designing-products/accessibility.md
3fd3d04
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@mouxdesignStephen DeLorme
Update guide/designing-products/accessibility.md
e45d184
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@mouxdesignStephen DeLorme
Update guide/designing-products/accessibility.md
3726f98
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@mouxdesignStephen DeLorme
Update guide/designing-products/accessibility.md
6e017f2
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@mouxdesign

mouxdesign commented May 23, 2022

Copy link
Copy Markdown
Collaborator

Just realized this was in draft mode. Sorry for providing such hyper-detailed feedback early when you may not have been ready for it.

Really appreciate your thorough feedback @sbddesign, very much appreciated. I've applied all those suggestions you've made.

@GBKS
GBKS marked this pull request as ready for review May 24, 2022 08:22
@GBKS
GBKS requested a review from sbddesignMay 24, 2022 08:26
@GBKS

GBKS commented May 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@sbddesign I think all your feedback is addressed and the page is ready for another review.

sbddesign
sbddesign approved these changes May 25, 2022
View reviewed changes

@sbddesignsbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sbddesignsbddesign mentioned this pull request May 31, 2022
Closed
Bosch-0
Bosch-0 approved these changes Jun 3, 2022
View reviewed changes

@Bosch-0Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM, great work on this page guys. I learnt a lot reading it

@Bosch-0
Bosch-0 merged commit cdfe088 into masterJun 3, 2022
@GBKS
GBKS deleted the feature/new-accessibility-page branch December 20, 2022 14:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mouxdesignmouxdesignmouxdesign left review comments
@sbddesignsbddesignsbddesign approved these changes
+1 more reviewer
@Bosch-0Bosch-0Bosch-0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mouxdesignmouxdesign

Labels

CopyTask is about improving text.Design bitcoin productsReferring to the Design BTC product section.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a page about accessibility

4 participants

@GBKS@mouxdesign@sbddesign@Bosch-0