[Flight] Fix the react-server-dom-rspack package contract - #1
Draft
BleedingDev wants to merge 1 commit into
Draft
Conversation
Remove the advertised plugin wrapper that points at an artifact this package does not build, along with stale node-register, unbundled, and ESM template residue. Rspack compiler integration remains owned by @rspack/core experiments.rsc. Keep the supported client, server, and static runtimes; restore the browser server loadServerAction export; narrow host entrypoints to Rspack-owned modules; and validate the assembled release through a real consumer, export-condition resolution, environment guards, and npm pack inventory.
|
Changed Files |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is intentionally stacked within
BleedingDev/reacton SyMind#1. It should be reviewed after that PR and can be retargeted toSyMind/react:react-server-dom-rspackonce it lands.It addresses only the assembled
react-server-dom-rspackpackage contract.The package advertises
./plugin, but its wrapper requires a CJS artifact that the package does not build. Rspack’s compiler integration instead lives in@rspack/corethroughexperiments.rsc.createPlugins().This PR:
./pluginexport and wrapper;loadServerActionon the browser server entrypoint;react-serverenvironment guards;workerd,deno,worker,node,edge-light,browser, and default conditions.No working Rspack compiler or runtime implementation is removed. If maintainers prefer an intentionally implemented compatibility plugin entry, that decision can be handled here without blocking SyMind#1.
How did you test this change?
After an exact experimental release rebuild:
check-changedpassed.git diff --checkpassed.