AbuShafrah-review

[muaawiyahtucker]

There was a rounding error that happened that wasn't resolved without setting the decimal point to 8 decimal. Without this, it occationally rounded down the satoshis resulting in a miscalculation.

Also, I changed the way the arrays were created to be more robust, along with adding quotations in accordance to ShellCheck 2086 https://www.shellcheck.net/wiki/SC2086.

[muaawiyahtucker]

As I was going through the material with the Bitshalah cohort, I was collecting the typo corrections, along with some code improvements.
I eventually put all the formatted text into an epub for anyone who wished to go through the material on their reading device, such as iBook or Kindle.

[shannona]

Sounds great! We are looking into how to do an updated version, not just pulling in all the PRs and resolving all the issues, but also updating to BTC 29.0. But, we're still seeking funding for it, so it's not quite on our TODO yet!

[muaawiyahtucker]

That's interesting. There were some further updates that I noticed but didn't haven the time to pencil them down. For example, the current material said there wasn't any swift libraries, but there are now. Also, the install process for c-lightning has changed from what's on the github to using poetry and Rust. I used the updated method to install CLN. So there are some rooms to update.

I was planning on using this material to teach, so would be interesting to further update where possible. Let me know if I can help in any way.