Uh oh!
There was an error while loading. Please reload this page.
Conversation
DrTaDa
commented
Mar 15, 2022
- Add a check that raises an exception if the voltage gets unrealistic
- Replace h.run by hfadvance in the NrnSimulator
- Add a check that raises an exception if the voltage gets unrealistic
| return neuron | ||
| def check_voltage_valid(self, icell, voltage_bound=200.): |
There was a problem hiding this comment.
I find this dangerous though. Ideally NEURON should detect if it gets values that it can't handle. Do we know what the effect this has on optimizations? I wouldn't be surprised if a lot of initial solutions might be out of bounds here.
There was a problem hiding this comment.
Ok,I will open an issue in Neuron
There was a problem hiding this comment.
The engineer who was looking into it is just back from vacation. He will resume working on it.
| try: | ||
| self.neuron.h.run() | ||
| self.neuron.h.finitialize() |
There was a problem hiding this comment.
Are we sure this 'exactly' replicates the 'run()' behavior of Neuron? We don't want to change results if not necessary.
| self.neuron.h.finitialize() | ||
| while self.neuron.h.t < self.neuron.h.tstop: | ||
| self.neuron.h.fadvance() | ||
| self.check_voltage_valid(icell) |
There was a problem hiding this comment.
We also need to check how this affects the simulation time.