Work toward build system with packages - #509
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Package paths are resolved incorrectly, and every package-enabled build currently exits before completion.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prepares the compiler and native build pipeline for package support and bundled JSON headers.
Changes:
- Adds package metadata loading and CLI parsing.
- Integrates JSON resources into native builds.
- Updates generated test Makefiles.
File summaries
| File | Description |
|---|---|
src/frontend/build_decls.ts |
Defines package metadata. |
src/cmd/workflows.ts |
Loads packages and parses package arguments. |
src/cmd/bosque.ts |
Adds package sources and JSON runtime copying. |
build/resource_copy.js |
Copies JSON build resources. |
build/Makefile |
Adds the JSON include directory. |
test/cpprun/cpprun_nf.ts |
Updates C++ test Makefile. |
test/documentation/docs_nf.ts |
Updates documentation-test Makefile. |
test/stdlib/stdlib_nf.ts |
Updates standard-library test Makefile. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+50
to
+53
| if(packageinfos.length !== 0) { | ||
| //TODO: wire this feature in | ||
| Status.error("Packages detected, but this feature is not yet implemented!\n"); | ||
| process.exit(1); |
| const pp = { | ||
| name: packageconfig.name as string, | ||
| packagepath: pkgpath, | ||
| bosquesrc: packageconfig.bosquesrc, |
| return packages; | ||
| } | ||
| catch (ex) { | ||
| Status.error(`Failed to load external package!\n`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working to support packages and a modular core library (with native).
Updating build and command line in preparation for enabling this.