Skip to content

[scene_manager] Allow setting delimiters for CSV output - #429

Merged
Breakthrough merged 2 commits into
mainfrom
issue-423-csv_separator
Nov 20, 2024
Merged

[scene_manager] Allow setting delimiters for CSV output#429
Breakthrough merged 2 commits into
mainfrom
issue-423-csv_separator

Conversation

@Breakthrough

@BreakthroughBreakthrough commented Sep 30, 2024

Copy link
Copy Markdown
Owner

Allows setting delimiters for both rows and columns for the write_scenes_list function as well as in the config file for the list-scenes command. #423

Outstanding Tasks:

  • Add CLI tests that verify output with goldens
  • Ensure CLI only allows 1-character separators are allowed (see TODO in code)
    • This is a limitation by the Python CSV module so this will only be enforced by the CLI to provide correct error messages to end users
  • Update changelog

@BreakthroughBreakthrough added this to the 0.6.5 milestone Sep 30, 2024
@BreakthroughBreakthrough linked an issue Sep 30, 2024 that may be closed by this pull request
@Breakthrough
Breakthrough changed the base branch from output-pipeline to mainOctober 19, 2024 23:48
@Breakthrough
Breakthrough changed the base branch from main to output-pipelineOctober 19, 2024 23:48
@Breakthrough
Breakthrough changed the base branch from output-pipeline to mainOctober 19, 2024 23:52
@Breakthrough
Breakthroughforce-pushed the issue-423-csv_separator branch from 7a81de2 to 8a83222CompareOctober 19, 2024 23:53
@Breakthrough
Breakthrough marked this pull request as draft October 19, 2024 23:54
@Breakthrough
Breakthroughforce-pushed the issue-423-csv_separator branch 2 times, most recently from 3f49828 to c7353acCompareOctober 21, 2024 01:36
@Breakthrough
Breakthrough marked this pull request as ready for review October 21, 2024 02:08
@Breakthrough
Breakthroughforce-pushed the main branch 2 times, most recently from 85d1bdd to 2c55a55CompareNovember 13, 2024 03:03
@Breakthrough
Breakthrough merged commit e1d86d9 into mainNov 20, 2024
@Breakthrough
Breakthrough deleted the issue-423-csv_separator branch November 20, 2024 02:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define csv separator

1 participant

@Breakthrough