Skip to content

BI-2167 - Lat and long values are getting swapped in the exp download file - #368

Merged
nickpalladino merged 1 commit into
developfrom
bug/BI-2167
Jul 2, 2024
Merged

BI-2167 - Lat and long values are getting swapped in the exp download file#368
nickpalladino merged 1 commit into
developfrom
bug/BI-2167

Conversation

@nickpalladino

@nickpalladinonickpalladino commented Jun 26, 2024

Copy link
Copy Markdown
Member

Description

Story:BI-2167

  • Ordering for geojson array for geocoordinates should have been [lon, lat, elevation], so fixed that
  • Sent out message on delta breed channel noting implications for uploads prior to v0.10 release
  • Shawn looked at production and there was no existing geocoordinate data that would need to be fixed

Dependencies

Testing

Given I have an experiment import file with lat and long values
When I upload the file and subsequently download it from deltabreed
Then the Lat Long columns match the file that I uploaded instead of reversed
Given I have an experiment import file with lat and long values
When I upload the file Then I should see Lat and Long values matching the file in the preview table
Given I have an experiment import file with lat and long values
When I upload the file And navigate to the experiments page for the created experiment
Then I should see Lat and Long values matching the experiment data table

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actionsgithub-actionsBot added the bug Something isn't working label Jun 26, 2024
@nickpalladino
nickpalladino requested review from a team, HMS17, davedrp and mlm483 and removed request for a team and mlm483June 26, 2024 18:34

@davedrpdavedrp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Test

@nickpalladino
nickpalladino merged commit a960d55 into developJul 2, 2024
@nickpalladino
nickpalladino deleted the bug/BI-2167 branch July 2, 2024 17:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino@davedrp@HMS17