Skip to content

BI-2372 Create Deltabreed List Controller - #434

Merged
dmeidlin merged 9 commits into
developfrom
feature/BI-2372
Jan 10, 2025
Merged

BI-2372 Create Deltabreed List Controller#434
dmeidlin merged 9 commits into
developfrom
feature/BI-2372

Conversation

@dmeidlin

@dmeidlindmeidlin commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

Description

Story:BI-2372

  • Removed GET /germplasm/lists/<listDbId/records and replaced with GET /germplasm?list=<listDbId> to follow the pattern expected for BrAPI lists in the future.
  • Created DELETE /lists/ with hardDelete query param for deleting a single list entity, and not deleting the list contents.

Dependencies

  • Brapi-java-test-server branch brapi-server-v2

Testing

Testing is satisfied by successful testing of BI-2373.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

Comment threadsrc/main/java/org/breedinginsight/brapi/v2/dao/BrAPIListDAO.java Outdated
Comment threadsrc/main/java/org/breedinginsight/brapi/v2/dao/BrAPIListDAO.java Outdated

@mlm483mlm483 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

Consider renaming the GermplasmQuery list field to listId for clarity.

@dmeidlin
dmeidlin marked this pull request as ready for review January 10, 2025 20:27
@dmeidlin
dmeidlin merged commit 7fabdbf into developJan 10, 2025
@dmeidlin
dmeidlin deleted the feature/BI-2372 branch January 10, 2025 20:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dmeidlin@HMS17@mlm483