Uh oh!
There was an error while loading. Please reload this page.
BI-2372 Create Deltabreed List Controller - #434
Merged
Conversation
dmeidlinforce-pushed
the
feature/BI-2372
branch
from
November 20, 2024 15:01
e35a615 to
095342fComparemlm483
reviewed
Nov 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
6 tasks
HMS17
approved these changes
Dec 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
mlm483
approved these changes
Dec 18, 2024
mlm483
left a comment
Contributor
There was a problem hiding this comment.
Tested, working.
Consider renaming the GermplasmQuery list field to listId for clarity.
Uh oh!
There was an error while loading. Please reload this page.
dmeidlinforce-pushed
the
feature/BI-2372
branch
from
December 20, 2024 15:31
dcf1954 to
710e677Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story:BI-2372
/germplasm/lists/<listDbId/recordsand replaced with GET/germplasm?list=<listDbId>to follow the pattern expected for BrAPI lists in the future.Dependencies
brapi-server-v2Testing
Testing is satisfied by successful testing of BI-2373.
Checklist: