Uh oh!
There was an error while loading. Please reload this page.
Apply BrAPI-server side Filtering/Sorting/Pagination to BI Experiments - #521
Merged
Conversation
Additionally, create utilities for developers to reuse
- This fixed unit test failures
5 tasks
HMS17
approved these changes
Jun 17, 2026
HMS17
left a comment
Contributor
There was a problem hiding this comment.
Code looks good, and light testing on local with small datasets passed
nickpalladino
commented
Aug 19, 2026
Member
@codex review |
To use Codex here, create a Codex account and connect to github. |
nickpalladino
requested changes
Aug 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- In MR Nick pointed out that because we are sending a post RQ to BrAPI with no ids in the case where no authorized IDs exist for a collaborator, all trials were being returned. This commit resolves that, and adds a new utility to ResponseUtils to produce empty BrAPI responses
nickpalladino
approved these changes
Aug 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story:BI-2861
To support the removal of the cache for TrialEntities, a generalized implementation of filtering and sorting was created for the prod server.
This body of changes modifies bi-api to utilize these new changes via search requests with the newly implemented SortBy and FilterBy request models that are now accessible via an updated brapi-java-client/model.
The changes to bi-api only affect Experiments/Trials, and should namely only really affect the data table seen in a Program's Experiments tab.
Included updates:
Dependencies
Testing
Experimentstab of a Program. Mess with filtering, testing case insensitivity, and different data types. For sorting, test the order of different columns and ASC vs DESC order. Mess with paging, try selecting different pages, and different number of records per pageChecklist: