Uh oh!
There was an error while loading. Please reload this page.
[BI-2911] Remove rest of CRUD operations for ObservationDAO - #532
Open
jloux-brapi wants to merge 6 commits into
Open
[BI-2911] Remove rest of CRUD operations for ObservationDAO#532jloux-brapi wants to merge 6 commits into
jloux-brapi wants to merge 6 commits into
Conversation
HMS17
requested changes
Jul 15, 2026
HMS17
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, just one comment/question
| @@ -79,75 +74,17 @@ public BrAPIObservationDAO(ProgramDAO programDAO, | |||
| @Property(name = "brapi.server.reference-source") String referenceSource, | |||
| @Property(name = "micronaut.bi.api.run-scheduled-tasks") boolean runScheduledTasks, | |||
Contributor
There was a problem hiding this comment.
should this runScheduledTasks also be removed?
CollaboratorAuthor
There was a problem hiding this comment.
Yup, good catch, removed.
HMS17
approved these changes
Jul 20, 2026
HMS17
left a comment
Contributor
There was a problem hiding this comment.
Looks good from a reading code angle!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story:BI-2911
cache.post()were removed and replaced withbrapiDAOUtil.post()cache.postThese()were removed and replaced withbrapiDAOUtil.put()Dependencies
Testing
Checklist: