Skip to content

[BI-2913] Remove cache.get() dependencies in BrAPIObservationUnitDAO - #533

Merged
jloux-brapi merged 3 commits into
epic/BI-2862from
feature/BI-2913
Aug 25, 2026
Merged

[BI-2913] Remove cache.get() dependencies in BrAPIObservationUnitDAO#533
jloux-brapi merged 3 commits into
epic/BI-2862from
feature/BI-2913

Conversation

@jloux-brapi

@jloux-brapijloux-brapi commented Jul 10, 2026•
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Story:BI-2913

  • Removed references to cache.get() and replaced with BrAPI Observation Unit GET
  • Removed unused ObservationUnitProcessor which referenced a method that was unused otherwise. This processor is unused today.
  • Added TODO improvement tickets for future cache removal work.

Dependencies

Testing

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@jloux-brapi
jloux-brapi requested review from a team and humsika and removed request for a teamJuly 10, 2026 19:04
humsika
humsika approved these changes Jul 13, 2026
View reviewed changes

@humsikahumsika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated the changes, looks good!

@jloux-brapijloux-brapi added the on hold Review, but do not merge until removed label Jul 13, 2026
Base automatically changed from feature/BI-2911 to epic/BI-2862August 25, 2026 19:08
@jloux-brapi
jloux-brapi merged commit c5aeb5f into epic/BI-2862Aug 25, 2026
4 of 6 checks passed
@jloux-brapi
jloux-brapi deleted the feature/BI-2913 branch August 25, 2026 19:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humsikahumsikahumsika approved these changes

Assignees

No one assigned

Labels

featureon holdReview, but do not merge until removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jloux-brapi@humsika