Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 1, 2025. It is now read-only.
BI-2688 - Delete Experiment Not working - #57
Closed
mlm483 wants to merge 1 commit into
Closed
Conversation
mlm483
requested review from
a team, davedrp and dmeidlin
and removed request for
a teamJuly 7, 2025 22:44
dmeidlin
left a comment
There was a problem hiding this comment.
What was the affect of the indexing on the time to write trials, observation units, observations, etc.?
davedrp
approved these changes
Jul 16, 2025
davedrp
left a comment
There was a problem hiding this comment.
The deleting works (and is much faster).
Preliminary testing show that the upload of a large experiment (see Driscols MET Experiment(1).xls in the Jirra story) is about the same as before the indexes were added.
mlm483
commented
Aug 1, 2025
Author
Closing in favor of Breeding-Insight#2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira Story
This PR adds indexes for the columns in related tables referenced in trigger functions that execute when soft_deleted columns are updated.
It greatly improves the performance of delete operations.
There is also a PR against
develop.Testing
germplasmandobservation_unittables, and at least 50,000 rows inobservation.UPDATE {table} SET soft_deleted = (NOT soft_deleted);, test how long it takes the trigger functions to run before and after creating the indexes from this PR. At a minimum I would test withgermplasmandtrial.