Toronto Voter Survey

[mikaalnaik]

Builds out the 2026 municipal election section around the candidate questionnaire: voters answer the same questions the candidates did, then see where they line up with the field.

Rebased on main now that the Toronto voter-guide/SEO pages (#74) have landed, so this PR is just the survey and candidate-answer work.

What's here

Voter survey (/toronto/vote/2026/survey)

• SurveyClient renders the York Factory-hosted questionnaire rather than a local copy, so the questions voters answer are the same ones sent to candidates. Multi-step form, one question at a time, with staggered field transitions (.step-field in globals.css).
• On submit, AlignmentResults scores the voter against every candidate who wrote back (src/lib/elections/alignment.ts) and shows the closest matches per race.
• AgreementChart / AnswerChart show how the field answered each question next to the voter's own pick.
• Server routes: /api/elections/survey (fetch + submit) and /api/elections/candidate-responses.

Candidate answers

• /toronto/vote/2026/mayor — the questionnaire read across the mayoral field as a SurveyGrid: candidates as columns, questions as rows, non-respondents marked as such.
• /toronto/vote/2026/mayor/candidates — new. The mayoral roster on a page of its own: the field is fifty-odd people and it was eating half the landing page. Grouped answered-first (a name vs. a position is the most useful sort available), surname order within each group, withdrawn candidates kept in a group at the foot.
• /toronto/vote/2026/issues — new. The whole field read issue-by-issue via FieldSentiment, one card per question, for the city-wide "where do they converge and split" view that a grid can't hold at 32 respondents.
• /toronto/vote/2026/wards/[ward] — WardDetail now carries each race's questionnaire answers, charted with CandidateDotPlot (a dot per candidate on the option they picked) rather than a dial — shares are meaningless at two-to-six respondents, and the dial could only ever mark one position.

Trilemma dial (src/components/charts/trilemma/) ported in for the three-way tradeoff questions; its palette is also what the dot plots and answer charts colour from, so the pages read as one system.

Shared pieces — SurveyGrid, AnswerChart, AnswerOptionList, CandidateDotPlot, CandidateSurveyAnswers, SurveyCta, FieldSentiment, plus src/lib/elections/{alignment,candidate-answers,candidate-responses,field-sentiment,survey,survey-answers,names,postal-code}.ts. ElectionLanding reworked around the new race entry points; postal-code normalization pulled out of the pledge route so the survey can share it.

Notes

• Candidate responses are fetched at request time from York Factory, so pages reflect late replies without a redeploy.
• tsc --noEmit clean; pnpm lint reports only the four pre-existing warnings on bills/* and state-of-the-nation/og-card.tsx.

[greptile-apps]

Greptile Summary

The PR adds a York Factory-backed Toronto voter questionnaire, candidate-alignment results, and several candidate-answer views.

• Adds survey loading, submission, scoring, and candidate-response APIs.
• Adds mayoral, ward, and issue-level questionnaire visualizations.
• Introduces shared election components and trilemma chart primitives.
• Reorganizes Toronto’s election landing and candidate roster pages.

Confidence Score: 4/5

The PR is not yet safe to merge because its survey load and submission flows still target York Factory routes that are not registered.

The outstanding backend-route issue remains: opening the survey depends on an unavailable remote GET route and converts that failure into a not-found page, while submitting answers targets an unavailable POST route and returns an error.

Files Needing Attention: src/lib/elections/survey.ts and src/app/api/elections/survey/route.ts

Important Files Changed

Filename	Overview
src/lib/elections/survey.ts	Defines and fetches the remote questionnaire, but its York Factory GET dependency remains unavailable in the related backend repository.
src/app/api/elections/survey/route.ts	Adds the submission proxy, but forwards completed surveys to an endpoint not registered in the related backend repository.
src/app/toronto/vote/2026/survey/SurveyClient.tsx	Implements the multi-step voter questionnaire and transitions into candidate-alignment results.
src/lib/elections/alignment.ts	Adds candidate scoring and race-level alignment calculations.
src/app/api/elections/candidate-responses/route.ts	Adds a ward-scoped response proxy that joins respondent data with Toronto candidate rosters.
src/components/elections/SurveyGrid.tsx	Adds the candidate-by-question grid used to present mayoral questionnaire answers.

Sequence Diagram

sequenceDiagram
participant V as Voter
participant T as Tradingpost
participant Y as York Factory
V->>T: Open survey page
T->>Y: "GET /elections/{election}/surveys/{survey}"
Y-->>T: Survey definition
T-->>V: Questionnaire
V->>T: Submit answers
T->>Y: "POST /elections/{election}/survey_responses"
Y-->>T: Region and submission result
T->>Y: GET candidate responses
Y-->>T: Candidate answers
T-->>V: Alignment results

Loading

_{Reviews (3): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile}

[greptile-apps]

Backend survey routes are missing

The survey page always requests GET /elections/{election}/surveys/{survey}, but the current York Factory election routes register only pledges, so the request returns 404 and loadSurvey turns the new page into a not-found response. The submission proxy likewise targets an unregistered POST /elections/{election}/survey_responses route, preventing responses from being recorded.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/lib/elections/survey.ts
Line: 108-111
Comment:
**Backend survey routes are missing**
The survey page always requests `GET /elections/{election}/surveys/{survey}`, but the current York Factory election routes register only pledges, so the request returns 404 and `loadSurvey` turns the new page into a not-found response. The submission proxy likewise targets an unregistered `POST /elections/{election}/survey_responses` route, preventing responses from being recorded.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.