You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change allows developers to run yarn dev and, assuming docker is installed, the database will start before running the api servers.
If you don't have docker, the dev scripts will fail. Let me know if you think docker is a reasonable dependency. I could make the new scripts exit early if docker is not detected.
Theoretically you dont need the individual scope#script scripts as turbo will automatically only run the script in projects where the script exists (eg. db:migrate only exists in @repo/db)
@Nudelsuppe42 Ah good point. Should I remove the scopes? I will say, it's nice that the scope makes it clear the script only runs in one package. But happy to remove them.
Also, i'd remove the changes in turbo.json. The PG stuff looks good to me
You mean the scope prefixes? Just removed them. I think I can't totally remove the scripts from turbo.json because of the dependency order (up -> wait -> migrate -> dev)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows developers to run
yarn devand, assuming docker is installed, the database will start before running the api servers.If you don't have docker, the dev scripts will fail. Let me know if you think docker is a reasonable dependency. I could make the new scripts exit early if docker is not detected.