Uh oh!
There was an error while loading. Please reload this page.
Add external measure manager for non-gem repos - #2
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for managing and consuming external (non-gem) OpenStudio measure repositories via a manifest, including install/list rake tasks and updated OSW path ordering so local measures take precedence.
Changes:
- Introduces
BOSS::ExternalMeasureRepoManager+ default manifest (config/external_measure_repos.yml) to resolve/install external measure roots. - Updates
BOSS::Boss#write_baseline_oswto ordermeasure_paths/file_pathsas: local → gem-discovered → external repos. - Adds unit tests for the manager and for Boss measure path ordering; updates CI to run the full RSpec suite.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/tests/unit/external_measure_repo_manager_spec.rb | Adds unit coverage for manifest parsing, validation, and resolved directories behavior. |
| spec/tests/unit/boss_spec.rb | Tests ordering/deduping of measure_paths when combining local, gem, and external repo roots. |
| README.md | Documents external measure installation/listing and precedence rules. |
| Rakefile | Adds measures:install_external and measures:list_external tasks. |
| lib/measures/.gitkeep | Ensures local measures directory exists in-repo. |
| lib/BOSS/external_measure_repo_manager.rb | New manager to validate manifest, clone/fetch repos (sparse checkout), and resolve measure roots. |
| lib/BOSS/constants.rb | Adds constants for local measures dir, external manifest path, and install directory. |
| lib/BOSS/boss.rb | Integrates external/local/gem path ordering into OSW generation and derives file_paths. |
| lib/boss_cli.rb | Updates CLI help text and changes run_osw argument handling. |
| Gemfile.lock | Adds RuboCop performance/checkstyle formatter dev dependencies. |
| config/external_measure_repos.yml | Ships default external measure manifest (local roots + comstock repo roots). |
| .github/workflows/ci.yml | Simplifies CI test execution to bundle exec rspec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Adds support for managing and consuming external (non-gem) OpenStudio measure repositories via a manifest, including install/list rake tasks and updated OSW path ordering so local measures take precedence.
Changes: