Uh oh!
There was an error while loading. Please reload this page.
Fix SQL parsing and HTML review findings - #15
Conversation
● Bring over the legacy HTML CSS and JavaScript asset folder. ● Add companion HTML documentation and migration notes.
● Exclude double-at SQL Server system variables from parameter parsing ● Keep real bind parameters discoverable beside @@rowcount expressions ● Add regression coverage for SQL Server system variable parsing
There was a problem hiding this comment.
Pull request overview
Updates DBAccess SQL parameter parsing to avoid treating SQL Server @@... system variables as bind parameters, and adds a new set of static HTML/CSS/JavaScript UI framework assets with documentation.
Changes:
- Refines DBAccess parameter parsing regexes to exclude SQL Server
@@system variables (e.g.,@@ROWCOUNT) while still capturing normal@Parambinds. - Adds a regression unit test covering
@@ROWCOUNTmixed with regular bind parameters. - Introduces a repo-level
HTML/UI framework (CSS + JS components) and accompanying migration/docs updates.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| Toolkit.Modern/Data/Database/DBAccess.Parameters.cs | Regex refactor to avoid parsing @@... system variables as bind parameters. |
| Toolkit.Modern.Tests/Unit/Data/Database/DBAccessParameterParsingSimpleTests.cs | Adds regression coverage ensuring @@ROWCOUNT doesn’t produce @ROWCOUNT. |
| MIGRATION-legacy-toolkit.md | Documents new repo-level HTML/ asset folder and doc location. |
| HTML/README.md | Adds UI framework overview and usage notes. |
| HTML/JavaScript/README.md | Documents the browser-side helper scripts and integration guidance. |
| HTML/JavaScript/ByteForge-utilities.js | Adds general client-side utilities (validation, clipboard, security hardening). |
| HTML/JavaScript/ByteForge-tri-state-toggle.js | Adds a tri-state toggle UI component. |
| HTML/JavaScript/ByteForge-multi-selector.js | Adds a two-list selector helper component. |
| HTML/JavaScript/ByteForge-modal.js | Adds a modal/notification system component. |
| HTML/JavaScript/ByteForge-calendar.js | Adds a custom date picker widget component. |
| HTML/JavaScript/ByteForge-bulk-processor.js | Adds a preview-then-apply bulk workflow controller. |
| HTML/CSS/ByteForge-ui.css | Adds styling for the new UI framework components (modal, calendar, toggles, etc.). |
| Docs/HTML.md | Adds a documentation copy for the UI framework. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
● Correct validation and calendar behavior flagged during review ● Harden modal, selector, and bulk summary rendering against unsafe HTML ● Fix case-sensitive documentation links
Uh oh!
There was an error while loading. Please reload this page.
Summary
Verification