Uh oh!
There was an error while loading. Please reload this page.
Fix build with musl - #6
Open
passgat wants to merge 1 commit into
Open
Conversation
This was exposed while integrating the package into Buildroot and testing its compilation with a musl-based toolchain: CANvenient_SocketCAN.c: In function 'socketcan_open': CANvenient_SocketCAN.c:186:24: error: storage size of 'tv' isn't known 186 | struct timeval tv; | ^~ CANvenient_SocketCAN.c: In function 'socketcan_recv': CANvenient_SocketCAN.c:364:36: error: invalid application of 'sizeof' to incomplete type 'struct timeval' 364 | char ctrlmsg[CMSG_SPACE(sizeof(struct timeval))]; | ^~~~~~ CANvenient_SocketCAN.c:406:28: error: invalid use of undefined type 'const struct timeval' 406 | *timestamp = tv->tv_sec * 1000000ULL + tv->tv_usec; | ^~ Include <sys/time.h> to fix the build. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Up to standards ✅🟢 Issues |
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewerTIP This summary will be updated as you push new changes.
passgat
commented
Sep 7, 2026
Author
A gentle ping. The patch has been applied in the Buildroot integration of CANopenterm package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was exposed while integrating the package into Buildroot and testing its compilation with a musl-based toolchain:
CANvenient_SocketCAN.c: In function 'socketcan_open':
CANvenient_SocketCAN.c:186:24: error: storage size of 'tv' isn't known
186 | struct timeval tv;
| ^~
CANvenient_SocketCAN.c: In function 'socketcan_recv':
CANvenient_SocketCAN.c:364:36: error: invalid application of 'sizeof' to incomplete type 'struct timeval'
364 | char ctrlmsg[CMSG_SPACE(sizeof(struct timeval))];
| ^~~~~~
CANvenient_SocketCAN.c:406:28: error: invalid use of undefined type 'const struct timeval'
406 | *timestamp = tv->tv_sec * 1000000ULL + tv->tv_usec;
| ^~
Include <sys/time.h> to fix the build.