Uh oh!
There was an error while loading. Please reload this page.
test(Tasks): Add comprehensive test suite for Tasks component - #434
Conversation
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
| jest.mock('@/components/ui/multi-select', () => ({ | ||
| MultiSelectFilter: jest.fn(({ title, completionStats }) => ( | ||
| <div data-testid={`multi-select-${title.toLowerCase()}`}> |
There was a problem hiding this comment.
hardcoded ids are better, for the time being
There was a problem hiding this comment.
@its-me-abhishek, I see this comment is on the pre-existing
data-testid line L48 left, not my new changes.
also, both id={id} and data-testid={title.toLowerCase()}
result in hardcoded values ("projects", "status", "tags")-
they're derived the same way
<MultiSelectFilter
id="projects"
title="Projects"
options={uniqueProjects}
selectedValues={selectedProjects}
onSelectionChange={setSelectedProjects}
className="hidden lg:flex min-w-[140px]"
icon={<Key label="p" />}
completionStats={projectStats}
/>
Could you clarify what change you'd like me to make?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Add tests for Keyboard Navigation (ArrowUp, ArrowDown, boundary stops)
- Add tests for Hotkey Shortcuts ('a', 'c', 'd', 'f', 'p', 'r', 's', 't', Enter)
- Add tests for complete/delete hotkeys when dialog is already open
- Add test for hotkeys disabled when input is focused
- Update MultiSelectFilter mock to use aria-expanded for behavior testing
- Remove unnecessary mock override in overdue filter test339f115 to
cf49bdfCompareUh oh!
There was an error while loading. Please reload this page.
ShivaGupta-14
commented
Jan 31, 2026
thanks for merging❤️ |
Description
Add tests for Keyboard Navigation (ArrowUp, ArrowDown, boundary stops)
Add tests for Hotkey Shortcuts ('a', 'c', 'd', 'f', 'p', 'r', 's', 't', Enter)
Add tests for complete/delete hotkeys when dialog is already open
Add test for hotkeys disabled when input is focused
Update MultiSelectFilter mock to use aria-expanded for behavior testing
Remove unnecessary mock override in overdue filter test
Tracking Issue : Tracking Issue: Tasks Component Test Improvements #433
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Before:
After: