Conversation
Caution Review failedFailed to post review comments. Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (26)
🧰 Additional context used🧬 Code graph analysis (1)src/hooks/persisted/usePlugins.ts (1)
🪛 RuboCop (1.76.1)ios/Podfile[fatal] 36-36: unexpected token tLPAREN2 (Lint/Syntax) 🪛 markdownlint-cli2 (0.17.2)CONTRIBUTING-NIX.md55-55: Fenced code blocks should have a language specified (MD040, fenced-code-language) WalkthroughMigrates tooling to pnpm and Rock across CI, dev, and build systems. Updates Android/iOS configuration to use Rock for autolinking and CLI entrypoints, adjusts Metro and Babel, upgrades Android/Gradle versions, revises localization initialization, and adds Rock config. Documentation and Nix shells updated to pnpm; package.json dependencies/scripts significantly revised. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev
participant CI as CI (GitHub Actions)
participant pnpm as pnpm
participant Rock as Rock CLI
participant Metro as Metro (with pnpm symlinks)
Dev->>CI: Push/PR
CI->>pnpm: Setup + cache (~/.pnpm-store, node_modules)
CI->>pnpm: pnpm install
CI->>Rock: rock start / build / type-check
Rock->>Metro: Start bundler (symlink-aware)
sequenceDiagram
autonumber
actor User
participant App as Android App
participant Entry as ReactNativeApplicationEntryPoint
participant JNI as OnLoad.cpp
participant Spec as FBReactNativeSpec
User->>App: Launch
App->>Entry: loadReactNative(this)
Note over App,Entry: Replaces SoLoader/new-arch guarded init
Entry->>JNI: Resolve JavaModuleProvider
JNI->>Spec: FBReactNativeSpec_ModuleProvider(name, params)
Spec-->>JNI: Module (or null)
JNI-->>Entry: Provider chain result
Entry-->>App: RN runtime loaded
sequenceDiagram
autonumber
participant Pod as CocoaPods (install)
participant RN as use_native_modules!
participant Rock as ['npx','rock','config','-p','ios']
Pod->>RN: Generate native modules config
RN->>Rock: Execute rock config -p ios
Rock-->>RN: Config output
RN-->>Pod: Apply config_command
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit