Skip to content

BibAuthority: people collection - #162

Open
jochenklein wants to merge 3 commits into
CERNDocumentServer:prodfrom
jochenklein:cds-bibauthority-people
Open

BibAuthority: people collection#162
jochenklein wants to merge 3 commits into
CERNDocumentServer:prodfrom
jochenklein:cds-bibauthority-people

Conversation

@jochenklein

Copy link
Copy Markdown

Adds a command line interface and bibsched tasklet to create and update the CERN people collection used by CDS. (Requires #140)

@jochenklein
jochenkleinforce-pushed the cds-bibauthority-people branch 3 times, most recently from 0747b1c to cb216c3CompareNovember 23, 2015 10:47
@jochenkleinjochenklein changed the title bibauthority: people collectionBibAuthority: people collectionNov 23, 2015
@jochenklein
jochenkleinforce-pushed the cds-bibauthority-people branch 24 times, most recently from 99b5de6 to ed92a1dCompareNovember 30, 2015 13:22
@jochenklein
jochenkleinforce-pushed the cds-bibauthority-people branch from ed92a1d to 075d342CompareJanuary 19, 2016 10:10
@egabancho

Copy link
Copy Markdown
Member

Do diff with production code before merging

author in query_author_source("") if
author.get("cernccid") and author.get("inspireid")
]
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed somehow, we shouldn't have complex function calls inside a config file specially if they relay in external services which might or might not work.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass


class Mapper:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jochenklein
jochenkleinforce-pushed the cds-bibauthority-people branch 2 times, most recently from 4471130 to 4cdeab9CompareMarch 17, 2016 10:17
* Adds config, mapper, and utils which are used by the command line
interface (CLI) 'bibauthority_people' and the bibsched tasklet
'bst_bibauthority_people_updater'.
Signed-off-by: Jochen Klein <j.klein@cern.ch>
* Adds a command line interface for mapping all CERN LDAP records
to MARC 21 authority records, writing to MARCXML, and uploading
to CDS.
* Adds CLI to makefile.
Signed-off-by: Jochen Klein <j.klein@cern.ch>
* Adds bibsched tasklet which updates the CERN people collection
on CDS.
* Adds tasklet to makefile.
Signed-off-by: Jochen Klein <j.klein@cern.ch>
@ludmilamarian

Copy link
Copy Markdown

I see a lot of references to CERN. Can you confirm that this shall not be an invenio PR? @egabancho@switowski

@egabancho

Copy link
Copy Markdown
Member

Confirmed, but I don't remember why I wrote this "note to self"

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jochenklein@egabancho@ludmilamarian