Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

add github actions for lint tests - #586

Open
ishanrai05 wants to merge 1 commit into
CMSCompOps:masterfrom
ishanrai05:irai-gh-actions
Open

add github actions for lint tests#586
ishanrai05 wants to merge 1 commit into
CMSCompOps:masterfrom
ishanrai05:irai-gh-actions

Conversation

@ishanrai05

Copy link
Copy Markdown
Contributor

Status

Tested on my branch

Description

Set up flake8 tests to check python syntax

Is it backward compatible (if not, which system it affects?)

yes

Related PRs

None

External dependencies / deployment changes

No.

@sharad1126sharad1126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's evaluate only the files which changes in a pull request or commits for now. Also, please make a new GH action and don't overwrite the GH action which exists previously.

Comment thread.github/workflows/check_syntax.yml Outdated
@ishanrai05ishanrai05 changed the title Set up flake8 test for github actionsadd github actions for lint testsJun 17, 2020
@sharad1126

sharad1126 commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

@ishanrai05 if I am not wrong, this GH action is suppose to check the python syntax for the whole GH repo codebase on master branch right?
If that is the case, doing it every 6 hours won't make sense.

@ishanrai05

Copy link
Copy Markdown
ContributorAuthor

Should I change it to once a day? Or a week?

@sharad1126

Copy link
Copy Markdown
Contributor

yeah let's do it for now once a day and then we will do our best to fix the errors asap and then change the cronjob later to once a week or something(maybe)

@ishanrai05
ishanrai05force-pushed the irai-gh-actions branch 3 times, most recently from de33ca3 to c1a6467CompareJune 27, 2020 11:03
@ishanrai05
ishanrai05force-pushed the irai-gh-actions branch 3 times, most recently from ceefcd1 to e9fae09CompareJuly 6, 2020 06:25
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ishanrai05@sharad1126