Uh oh!
There was an error while loading. Please reload this page.
BB2-3391: Adjust C4DIC FE sample client - #79
Merged
Conversation
jimmyfagan
marked this pull request as ready for review
September 24, 2024 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3391
What Does This PR Do?
This PR adjusts the rendering of the FE sample client for C4DIC. There is still more work to be done, but this at least sets up the general format of a card that resembles the designs in Figma.
What Should Reviewers Watch For?
Especially since I don't have a lot of FE experience, if any of this significantly breaks norms or is bad practice, please point that out. Anything that definitely needs to be done in a future PR that is not already marked with a TODO should be called out as well.
Validation
I've verified this by running locally against my local server which is running the feature branch of the web server repo. To do this, make sure your HOST_IP in docker-compose.yml matches your local IP (can be viewed in your wifi settings under the details of your current connection).
Results should look like this:
