Skip to content

tropical rain - #39

Closed
pfhein wants to merge 1 commit into
masterfrom
tropical_rain
Closed

tropical rain#39
pfhein wants to merge 1 commit into
masterfrom
tropical_rain

Conversation

@pfhein

@pfheinpfhein commented Jul 28, 2016

Copy link
Copy Markdown

csu_blended_rain_tropical.py has Z-R relationships from the DYNAMO field project. (Thompson paper)

@pfhein
Add files via upload
855d6e9
csu_blended_rain_tropical.py has Z-R relationships from the DYNAMO field project. (Thompson paper)
tjlang
tjlang reviewed Jul 28, 2016
View reviewed changes
Comment threadcsu_blended_rain_tropical.py
from csu_liquid_ice_mass import linearize, get_linear_fits


def calc_rain_zr(dz, a=216, b=1.39, band='S'):

@tjlangtjlangJul 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

band keyword unnecessary here.

@tjlang

tjlang commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

I am going to move the base rainfall functions in csu_blended_rain.py the to the common.py file. That way, they can be imported where they are needed and thus we can remove duplicate code. When that is done, you should import the R-Kdp functions, etc. from there.

tjlang
tjlang reviewed Jul 28, 2016
View reviewed changes
Comment threadcsu_blended_rain_tropical.py
return r_blended, meth


def _check_for_array(dz, zdr, kdp):

@tjlangtjlangJul 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function already exists in common.py. Please just import from there.

@tjlang

tjlang commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

OK, I updated the csu_blended_rain and common modules. Now you should alter the tropical code to import the base rain functions (e.g., R-Kdp) and _check_for_array from common. In addition, you should import the main tropical function to be part of csu_blended_rain. That is, put from .csu_blended_rain_tropical import calc_blended_rain_tropical in csu_blended_rain.py. Thanks!

@tjlang

tjlang commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

Closing this because of merger of #41.

@tjlangtjlang closed this Aug 9, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pfhein@tjlang