Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Reasoning fixes - #37

Open
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix
Open

Reasoning fixes#37
skrimix wants to merge 2 commits into
CaddyGlow:mainfrom
skrimix:fix/thinking-fix

Conversation

@skrimix

Copy link
Copy Markdown

This PR fixes several issues around handling thinking blocks:

Anthropic API: Accept thinking blocks in requests

Clients that try to pass thinking blocks back in consecutive requests were getting an error:

body -> messages -> 1 -> content -> str: Input should be a valid string;
body -> messages -> 1 -> content -> list[...] -> 0: Input tag 'thinking' found using 'type' does not match any of the expected tags: 'text', 'image', 'tool_use', 'tool_result'

Fix: Added ThinkingBlock and RedactedThinkingBlock to the list of accepted request content blocks.

OpenAI API: Use more common thinking tag format

Thinking blocks were formatted as <thinking signature="Eok...">, which I'm not sure there's any client that can handle.

Fix: Changed to the common <think> tag format.

OpenAI API: Fix streaming reasoning chunks

When streaming reasoning content, each chunk was being enclosed in its own thinking tag, resulting in broken output:

<thinking>User</thinking><thinking> wants to simpl</thinking><thinking>ify -</thinking>...

Fix: Moved the enclosing tag logic into the start and stop event handlers so the tags wrap the entire thinking content rather than each chunk.

@CaddyGlow

Copy link
Copy Markdown
Owner

@skrimix thank you.

Renaming the "thinking" block to "think" is fine. However, we should keep the signature attribute or pass it back another way. Does removing it cause issues with tools that handle think blocks?

From what I remember, I included the signature so we can reconstruct the thinking block when needed for tool use. I don't know how other tools handle this, but Anthropic requires it.

https://platform.claude.com/docs/en/api/messages#thinking_block

https://platform.claude.com/docs/en/build-with-claude/extended-thinking

"Preserving thinking blocks: During tool use, you must pass thinking blocks back to the API for the last assistant message. Include the complete unmodified block back to the API to maintain reasoning continuity."

https://platform.claude.com/docs/en/build-with-claude/extended-thinking#preserving-thinking-blocks

"During tool use, you must pass thinking blocks back to the API, and you must include the complete unmodified block back to the API. This is critical for maintaining the model's reasoning flow and conversation integrity."

@skrimix

Copy link
Copy Markdown
Author

I'll be honest, I didn't look too much into the tool calling side of things, since that isn't in my use case and so I missed that and likely broke whatever handling is there. I apologize.
As far as I can tell, handling reasoning and tool calling is tricky, since Responses API and Messages API handle things differently, and Chat Completions just doesn't have "passing back thinking" in any standardized way.

Responses API -> Messages API

In this case I guess we could try to glue it together by treating "thinking" field as "summary", and "signature" as "encrypted_content". Not sure.

Chat Completions API -> Messages API

This is even messier. Many providers don't support passing thinking in requests, so I'm guessing clients too. Those who do support that (e.g. Z.AI, Moonshot) use a simple "reasoning_context" text field, which isn't enough for handling Anthropic.
Since it's normal* for OpenAI clients to simply strip the thinking parts of responses perhaps it might even be desirable to intentionally avoid the parsing by using custom <thinking signature="..."> tags. I can revert the change around this part if you want.

    • my experience with custom providers is mostly through simpler chatbot kinda clients without much tool use, so I might be latest info.

LiteLLM's example

LiteLLM seems to be using both "reasoning_content" and a different "thinking_blocks" field specific to Anthropic, on their Chat Completions endpoint.
"Compatibility Notice
Anthropic extended thinking with tool calling is not fully compatible with OpenAI-compatible API clients. This is due to fundamental architectural differences between how OpenAI and Anthropic handle reasoning in multi-turn conversations.

When using Anthropic models with thinking enabled and tool calling, you must include thinking_blocks from the previous assistant response when sending tool results back. Failure to do so will result in a 400 Bad Request error."
This might be a viable approach. However, when I tried to trace all handling of thinking blocks around the code I quickly got lost, and I'm not yet comfortable with delegating everything to CC, so I probably won't be of much help here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of “thinking”/reasoning blocks across Anthropic and OpenAI compatibility layers, ensuring request validation accepts thinking blocks and streaming output wraps reasoning in a single tag pair.

Changes:

  • Accept thinking and redacted_thinking blocks in Anthropic request content validation.
  • Switch OpenAI-facing reasoning markup from <thinking ...> to <think>.
  • Fix streaming so <think>/</think> wrap the entire thinking block rather than each delta chunk.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
ccproxy/llms/models/anthropic.pyExpands request content block union to accept thinking-related blocks.
ccproxy/llms/formatters/anthropic_to_openai/streams.pyMoves <think> wrapping to block start/stop events for correct streaming output.
ccproxy/llms/formatters/anthropic_to_openai/responses.pyNormalizes non-streaming conversions to use <think> and skips redacted thinking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1396 to +1402
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenAI-compatible streaming, delta.role is typically only sent once at the start of the assistant message (many clients assume subsequent chunks omit it). For these synthetic <think> wrapper chunks, consider omitting role (i.e., only set content) or only including role if it hasn’t been emitted yet for the message.

Copilot uses AI. Check for mistakes.
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="</think>"

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the opening-tag emission: emitting delta.role=\"assistant\" on this closing-tag chunk may be inconsistent with common streaming expectations. Prefer omitting role (or gate it behind a ‘role already emitted’ flag) for these wrapper-only chunks.

Suggested change
role="assistant", content="</think>"
content="</think>"

Copilot uses AI. Check for mistakes.
Comment on lines +1390 to +1404
yield openai_models.ChatCompletionChunk(
id="chatcmpl-stream",
object="chat.completion.chunk",
created=0,
model=model_id,
choices=[
openai_models.StreamingChoice(
index=0,
delta=openai_models.DeltaMessage(
role="assistant", content="<think>"
),
finish_reason=None,
)
],
)

CopilotAIFeb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChatCompletionChunk construction for emitting wrapper tags is duplicated (opening and closing) with many identical fields. Consider extracting a small helper/factory (e.g., emit_text_chunk(content: str, *, role: str | None = None)) to reduce repetition and the risk of future inconsistencies across these synthetic chunks.

Copilot uses AI. Check for mistakes.
@CaddyGlow

Copy link
Copy Markdown
Owner

@copilot open a new pull request to apply changes based on the comments in this thread

@nikhilbatra789work

Copy link
Copy Markdown

@CaddyGlow
Are you planning to add support for new claude and codex models support?

@JiwaniZakirJiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The streaming chunks emitted for <think> and </think> tags in streams.py use hardcoded id="chatcmpl-stream" and created=0, which will likely differ from the surrounding stream chunks that carry real IDs and timestamps — clients that validate chunk ID consistency across a stream will break. These values should be threaded in from the outer stream context, similar to how other chunks in the same generator are constructed.

The <think> opening chunk also sets role="assistant" in the DeltaMessage. In the OpenAI streaming protocol, role is only sent in the first delta of a message; repeating it mid-stream can confuse strict clients. The </think> closing chunk doesn't set role, so the two are already inconsistent with each other.

In responses.py, redacted_thinking blocks are explicitly skipped with continue, but in the streaming path (content_block_start), redacted_thinking is handled only implicitly — the handler checks type == "thinking" and falls through. If a redacted_thinking delta somehow contains a "text" key, _anthropic_delta_to_text would emit it as plain text since it only checks for block_type == "thinking" before the text fallback. An explicit guard matching the non-streaming path's continue would be safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skrimix@CaddyGlow@nikhilbatra789work@JiwaniZakir