Uh oh!
There was an error while loading. Please reload this page.
Fix Deserialization error when "extensions" contains "extra" field - #10
Merged
Conversation
nitram22
commented
Jul 9, 2020
ContributorAuthor
The llinked issue is: #7 Unfortunately i can't link this pull request myself. |
nitram22
commented
Nov 4, 2020
ContributorAuthor
Could you please merge this if the solution is still okay? |
nitram22
commented
Jan 13, 2021
ContributorAuthor
Hi Josh, could you please build a new release so the error doesn't occur anymore ? Thank you! |
joshbooks
commented
Jan 13, 2021
Contributor
@nitram22 done |
nitram22
commented
Jan 14, 2021
ContributorAuthor
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to fix the issue that the library isn't able to parse an entry that contains the field "extra" in the "extensions" section.
@joshbooks has tried to fix the bug before, so I used his solution as a starting point. Now the code doesn't create an infinite loop anymore and still parses the extensions correctly.
Maybe you guys could look into it and see if it works for you.
Unfortunately I had to replace the NotImplementedException with an UnsupportedOperationException, because I work with OpenJDK and have no access to the reflectiveObjects packages.