Select correct self link when parsing Webfinger response (#31110)

[hackal]

✨

Description by Cal

PR Description

This PR introduces a new feature for parsing Webfinger responses, including enhancements to the handling of self links and the addition of type checks for the links.

Diagrams of code changes

sequenceDiagram
participant User
participant Webfinger
participant ActivityPubService
participant AccountService
User->>Webfinger: Request Webfinger info
Webfinger-->>User: Return Webfinger response with self link
User->>ActivityPubService: Call to fetch remote account
ActivityPubService->>AccountService: Validate account using self link
AccountService-->>ActivityPubService: Return account details
ActivityPubService-->>User: Return account information

Loading

Key Issues

None

Files Changed

File: /.callstack.yaml

Configuration file for the review process.

File: /.github/workflows/reviewer.yml

GitHub Actions workflow for PR review.

File: /app/lib/webfinger.rb

Improvements to the Webfinger response handling, including self link parsing.

File: /app/services/activitypub/fetch_remote_actor_service.rb

Updated to use the new self link method for validation.

File: /app/services/resolve_account_service.rb

Refactored to utilize the new self link method.

File: /spec/fixtures/requests/activitypub-webfinger.txt

Updated test fixture for activitypub Webfinger response.

File: /spec/fixtures/requests/webfinger.txt

Updated test fixture for Webfinger response.

File: /spec/lib/webfinger_spec.rb

Added tests for the new self link functionality.

File: /spec/services/activitypub/fetch_remote_account_service_spec.rb

Updated tests to reflect changes in self link handling.

File: /spec/services/activitypub/fetch_remote_actor_service_spec.rb

Updated tests to reflect changes in self link handling.

File: /spec/services/activitypub/process_account_service_spec.rb

Updated tests to reflect changes in self link handling.

File: /spec/services/activitypub/fetch_remote_key_service_spec.rb

Updated tests to reflect changes in self link handling.

[adam-callstackai-action-localhost]

No issues found.