Uh oh!
There was an error while loading. Please reload this page.
iOS 26/27/Liquid Glass compatibility - #158
Open
mmertsock wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires Xcode 27
Various toolbar/button changes to support iOS 26/27 and Liquid Glass (none of these changes apply for devices running iOS 18 or earlier):
Enhancement:
Asking for feedback or contrary opinions on design choices:
Developer testing with Xcode (before this is fully integrated into MyDataHelps)
The easiest way to test is to use the corresponding CEVResearchKit PR, and run the CEVRKUITestVehicle app on a simulator or device. Suggested surveys: ConsentStep FormStep, FullBattery, ProgressOptions, QuestionStepText, QuestionStepTextAllowMultipleLinesInput. Don't forget to toggle the "version 2" switch to test both versions of ResearchKit.
QA testing
TODO
Screenshots
Each set of screenshots shows (1) the current appearance / iOS 18 appearance with this PR, (2) various UI bugs with Xcode 27 without the fixes in this PR, (3) the final UI rendered with this PR.
Basic bar buttons and progress bar
Save/discard prompt
Navigation bar opacity
Note the bug in the center screenshot: a hard edge halfway down the nav bar.
RK1 text-style progress indicator alternative
RK2 "Done" button above keyboard