Skip to content

fix: don't force a full render on no-op agent state republish - #6

Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom
fix/idle-render-loop-damage-gate
Draft

fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom
fix/idle-render-loop-damage-gate

Conversation

@Castrozan

@CastrozanCastrozan commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.

Summary

  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.

Tests

  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings

@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan

Castrozan commented Jul 12, 2026

Copy link
Copy Markdown
OwnerAuthor

Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).

Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.

Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: don't force a full render on no-op agent state republish by Castrozan · Pull Request #6 · Castrozan/herdr · GitHub
Skip to content
fix: don't force a full render on no-op agent state republish - #6
Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Draft
fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Conversation
@Castrozan
@CastrozanCastrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

Owner
Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.
Summary
  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.
Tests
  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings
@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan
Castrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

OwnerAuthor
Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).
Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.
Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: don't force a full render on no-op agent state republish by Castrozan · Pull Request #6 · Castrozan/herdr · GitHub
Skip to content
fix: don't force a full render on no-op agent state republish - #6
Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Draft
fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Conversation
@Castrozan
@CastrozanCastrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

Owner
Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.
Summary
  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.
Tests
  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings
@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan
Castrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

OwnerAuthor
Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).
Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.
Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: don't force a full render on no-op agent state republish by Castrozan · Pull Request #6 · Castrozan/herdr · GitHub
Skip to content
fix: don't force a full render on no-op agent state republish - #6
Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Draft
fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Conversation
@Castrozan
@CastrozanCastrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

Owner
Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.
Summary
  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.
Tests
  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings
@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan
Castrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

OwnerAuthor
Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).
Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.
Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix: don't force a full render on no-op agent state republish by Castrozan · Pull Request #6 · Castrozan/herdr · GitHub
Skip to content
fix: don't force a full render on no-op agent state republish - #6
Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Draft
fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Conversation
@Castrozan
@CastrozanCastrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

Owner
Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.
Summary
  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.
Tests
  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings
@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan
Castrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

OwnerAuthor
Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).
Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.
Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: don't force a full render on no-op agent state republish by Castrozan · Pull Request #6 · Castrozan/herdr · GitHub
Skip to content
fix: don't force a full render on no-op agent state republish - #6
Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Draft
fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Conversation
@Castrozan
@CastrozanCastrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

Owner
Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.
Summary
  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.
Tests
  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings
@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan
Castrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

OwnerAuthor
Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).
Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.
Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
fix: don't force a full render on no-op agent state republish by Castrozan · Pull Request #6 · Castrozan/herdr · GitHub
Skip to content
fix: don't force a full render on no-op agent state republish - #6
Draft
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Draft
fix: don't force a full render on no-op agent state republish#6
Castrozan wants to merge 1 commit into
upstream-masterfrom 
fix/idle-render-loop-damage-gate
Conversation
@Castrozan
@CastrozanCastrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

Owner
Draft preview of the upstream PR against ogulcancelik/herdr. Base upstream-master mirrors upstream master (4617456), so the diff is exactly the single fix commit.
Summary
  • The agent-state StateChanged handler always returned true, forcing a full render even when nothing visible changed. A stable agent republishing the same state (a blocked agent re-reporting Blocked) redrew the whole frame on every republish.
  • Gate the full render on an actual visible change: agent state, agent label, or toast. A no-op republish no longer forces a render, and the blocker stays displayed.
Tests
  • stable_blocker_republish_does_not_force_full_render: entering Blocked forces a render; a no-op republish does not, and the blocker stays shown.
  • cargo clippy --all-targets -- -D warnings
@Castrozan
fix(render): don't force a full render on no-op agent state republish
1eabcf4
A visible, stable blocker republishes its unchanged AgentState every
STABLE_VISIBLE_SIGNAL_REFRESH (~800ms). The AppEvent::StateChanged arm
in the headless render loop returned an unconditional `true`, forcing
needs_full_render and a full compute_view + ratatui draw + frame
extraction every interval per blocked agent, only for prepare_frame to
discard the resulting byte-identical frame. That is a fixed idle
CPU/wakeup cost scaling with blocked-agent count (upstream herdrdev#726, herdrdev#1158).
Return whether the state change actually alters the rendered surface
(effective state, agent label, or toast) instead of always true. The
state mutation and fallback_observed_at bookkeeping still run before the
return, so delayed notifications are unaffected; every real transition
still forces a render and the retained path remains the safety net.
Adds a regression test asserting a no-op stable-blocker republish does
not force a full render while the blocker stays displayed.
@Castrozan
Castrozan
commented
Jul 12, 2026

Copy link


Copy Markdown

OwnerAuthor
Upstream tracking. Relates to the open herdr discussion "Reduce the CPU load when agent is running": herdrdev#399, where the maintainer has already done render optimizations. This fix removes one redundant class: a stable agent republishing the same state forced a full-frame redraw, and it now renders only on a real visible change (agent state, label, or toast).
Tangential, not a duplicate: herdrdev#1265 (client render cost while the app is hidden) is a different render-cost path.
Holding this PR until a maintainer approves the contribution path per herdr CONTRIBUTING: a first-time contributor needs a maintainer /approve into APPROVED_CONTRIBUTORS before an upstream PR.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Castrozan