Read the child's identifiers in clearChild()

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30

[daedeloth]

PropertySetter::clearChild() read its identifier list from $field->getResourceDefinition() — the parent's — while the entity it inspects ($existingChild) is a child. The identical guard in removeAllChildrenExcept(), a few lines below, correctly uses $field->getChildResourceDefinition().

Impact

When the parent resource definition declares no identifier of its own — legal, and normal for a resource only ever reached through its parent — getIdentifiers() is empty, entityExists() returns false and clearChild() returns early. Sending null for a cardinality-one relationship then silently does not unlink it, while the write reports success.

Fix

One line: use getChildResourceDefinition().

The guard itself stays. It is there so a child the parent only just created in the same request is not thrown away instead of unlinked, and that behaviour is now covered too.

Tests

tests/ClearChildTest.php, three cases:

• parent declares no identifier, existing child, null → cleared (this is the failing case; before the fix the child stayed linked)
• parent declares an identifier → cleared (the shape that happened to work, so the fix can't trade one broken shape for another)
• existing child carries no identifier, i.e. never persisted → not cleared (what the guard is for)

Both directions verified by mutation: keeping the old parent-side lookup fails the first test, deleting the guard entirely fails the third.

Other call sites

Audited every other $field->getResourceDefinition() in src/. None makes the same mistake — ResolverBase::callEntitySpecificMethodIfExists() (eager-load method on the owning class), PropertyResolver's cache key, and the InvalidPropertyException message all legitimately mean the field's owner. No further changes.

Suite: 70 tests, 214 assertions, green (67/210 on master + 3 new).

Fixes#30