Skip to content

Support setting front or back image as thumbnail - #1934

Merged
TheLastProject merged 1 commit into
mainfrom
feature/1675
Jul 13, 2024
Merged

Support setting front or back image as thumbnail#1934
TheLastProject merged 1 commit into
mainfrom
feature/1675

Conversation

@TheLastProject

@TheLastProject TheLastProject commented Jun 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #1675

  • Allow setting thumbnail to front or back image through thumbnail menu
  • Ask the user if they want to update the thumbnail after changing the front image (maybe, not sure if a good idea)

This was referenced Jun 16, 2024
Closed
Closed
@TheLastProject
TheLastProject marked this pull request as draft June 16, 2024 21:14
obfusk
obfusk reviewed Jun 17, 2024
View reviewed changes
Comment thread app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java Outdated
obfusk
obfusk reviewed Jun 17, 2024
View reviewed changes
Comment thread app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java Outdated
@TheLastProject
TheLastProject force-pushed the feature/1675 branch 2 times, most recently from 7020911 to 7c65f43 Compare June 17, 2024 19:03
@TheLastProject
TheLastProject marked this pull request as ready for review June 17, 2024 19:57
@TheLastProject
TheLastProject merged commit 4f13827 into main Jul 13, 2024
@TheLastProject
TheLastProject deleted the feature/1675 branch July 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@obfusk obfusk obfusk left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support thumbnail from already added photos

2 participants

@TheLastProject @obfusk